You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Ted Yu (Issue Comment Edited) (JIRA)" <ji...@apache.org> on 2011/10/28 06:38:32 UTC
[jira] [Issue Comment Edited] (HBASE-4528) The put operation can
release the rowlock before sync-ing the Hlog
[ https://issues.apache.org/jira/browse/HBASE-4528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13137922#comment-13137922 ]
Ted Yu edited comment on HBASE-4528 at 10/28/11 4:37 AM:
---------------------------------------------------------
>From src/hdfs/org/apache/hadoop/hdfs/DFSClient.java:
{code}
private void closeThreads() throws IOException {
try {
streamer.close();
streamer.join();
{code}
Besides closeInternal(), closeThreads() may be called from sync().
Looks like closeThreads() should be made re-entrant (by adding streamer = null; assignment after streamer.join() call).
So ignoring NPE shouldn't be a problem.
TRUNK build is broken at the moment.
I will try to reproduce the NPE after TRUNK becomes stable.
was (Author: yuzhihong@gmail.com):
From src/hdfs/org/apache/hadoop/hdfs/DFSClient.java:
{code}
private void closeThreads() throws IOException {
try {
streamer.close();
{code}
Besides closeInternal(), closeThreads() may be called from sync().
Looks like closeThreads() should be made re-entrant.
TRUNK build is broken at the moment.
I will try to reproduce the NPE after TRUNK becomes stable.
> The put operation can release the rowlock before sync-ing the Hlog
> ------------------------------------------------------------------
>
> Key: HBASE-4528
> URL: https://issues.apache.org/jira/browse/HBASE-4528
> Project: HBase
> Issue Type: Improvement
> Components: regionserver
> Reporter: dhruba borthakur
> Assignee: dhruba borthakur
> Fix For: 0.94.0
>
> Attachments: 4528-trunk.txt, HBASE-4528-Trunk-FINAL.patch, appendNoSync5.txt, appendNoSyncPut1.txt, appendNoSyncPut2.txt, appendNoSyncPut3.txt, appendNoSyncPut4.txt, appendNoSyncPut5.txt, appendNoSyncPut6.txt, appendNoSyncPut7.txt, appendNoSyncPut8.txt
>
>
> This allows for better throughput when there are hot rows. A single row update improves from 100 puts/sec/server to 5000 puts/sec/server.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira