You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@cassandra.apache.org by GitBox <gi...@apache.org> on 2021/12/23 22:45:45 UTC

[GitHub] [cassandra-website] michaelsembwever opened a new pull request #86: just do `ant gen-doc` instead

michaelsembwever opened a new pull request #86:
URL: https://github.com/apache/cassandra-website/pull/86


   as all cassandra sources that have an antora build and asciidocs also have the gen-nodetool-docs.py and convert_yaml_to_adoc.py


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org

[GitHub] [cassandra-website] michaelsembwever commented on pull request #86: just do `ant gen-doc` instead

Posted by GitBox <gi...@apache.org>.
michaelsembwever commented on pull request #86:
URL: https://github.com/apache/cassandra-website/pull/86#issuecomment-1014305614


   manually merged with https://github.com/apache/cassandra-website/commit/217b35b4f26b5d71388926d09b526d53b8fecf01


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org

[GitHub] [cassandra-website] michaelsembwever commented on pull request #86: just do `ant gen-doc` instead

Posted by GitBox <gi...@apache.org>.
michaelsembwever commented on pull request #86:
URL: https://github.com/apache/cassandra-website/pull/86#issuecomment-1000552401


   depends on https://github.com/polandll/cassandra/pull/16
   
   @ossarga 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org

[GitHub] [cassandra-website] michaelsembwever closed pull request #86: just do `ant gen-doc` instead

Posted by GitBox <gi...@apache.org>.
michaelsembwever closed pull request #86:
URL: https://github.com/apache/cassandra-website/pull/86


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org

[GitHub] [cassandra-website] ossarga commented on pull request #86: just do `ant gen-doc` instead

Posted by GitBox <gi...@apache.org>.
ossarga commented on pull request #86:
URL: https://github.com/apache/cassandra-website/pull/86#issuecomment-1000566836


   > quick question: why isn't -u cassandra-website:$(pwd) the default?
   
   @michaelsembwever it is. The `./run.sh` script takes care of this in the [run_docker_website_command](https://github.com/apache/cassandra-website/blob/trunk/run.sh#L489-L505) function.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org

[GitHub] [cassandra-website] michaelsembwever commented on pull request #86: just do `ant gen-doc` instead

Posted by GitBox <gi...@apache.org>.
michaelsembwever commented on pull request #86:
URL: https://github.com/apache/cassandra-website/pull/86#issuecomment-1000820021


   > The ./run.sh script takes care of this in the run_docker_website_command function.
   
   Cool. When I was testing this PR I had to supply that option. The first run without it did not pick up my modifications. I can debug and further validate in a separate issue/PR later on.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org

[GitHub] [cassandra-website] ossarga commented on pull request #86: just do `ant gen-doc` instead

Posted by GitBox <gi...@apache.org>.
ossarga commented on pull request #86:
URL: https://github.com/apache/cassandra-website/pull/86#issuecomment-1013970246


   @michaelsembwever yes, these changes are fine. I tested the change just after the latest commit (66cce0a) was pushed to the branch. It all worked fine for me.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org

[GitHub] [cassandra-website] ossarga edited a comment on pull request #86: just do `ant gen-doc` instead

Posted by GitBox <gi...@apache.org>.
ossarga edited a comment on pull request #86:
URL: https://github.com/apache/cassandra-website/pull/86#issuecomment-1013970246


   @michaelsembwever yes, these changes are good to commit. I tested the change in conjunction with the Cassandra changes, just after the latest commit (66cce0a) was pushed to the branch. It all worked fine for me.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org

[GitHub] [cassandra-website] michaelsembwever commented on pull request #86: just do `ant gen-doc` instead

Posted by GitBox <gi...@apache.org>.
michaelsembwever commented on pull request #86:
URL: https://github.com/apache/cassandra-website/pull/86#issuecomment-1013664520


   This is ready to go out. (I forgot about it, it is still part of CASSANDRA-16763)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org

[GitHub] [cassandra-website] michaelsembwever commented on pull request #86: just do `ant gen-doc` instead

Posted by GitBox <gi...@apache.org>.
michaelsembwever commented on pull request #86:
URL: https://github.com/apache/cassandra-website/pull/86#issuecomment-1000554876


   @ossarga , quick question: why isn't `-u cassandra-website:$(pwd)` the default? 
   (and when would you want to have cassandra-website something else than the current git working directory you are in?)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org