You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by "Stuart Bain (JIRA)" <ji...@apache.org> on 2006/11/09 16:19:02 UTC

[jira] Created: (AMQ-1037) IsAdvisory method of ActiveMQDestination incorrectly returns False for Advisory messages

IsAdvisory method of ActiveMQDestination incorrectly returns False for Advisory messages
----------------------------------------------------------------------------------------

                 Key: AMQ-1037
                 URL: https://issues.apache.org/activemq/browse/AMQ-1037
             Project: ActiveMQ
          Issue Type: Bug
          Components: NMS (C# client)
    Affects Versions: 4.x
         Environment: Using latest SVN checkout of DotNetClient
            Reporter: Stuart Bain
            Priority: Minor
         Attachments: ActiveMQDestination.patch

The IsAdvisory method of the ActiveMQDestination class incorrectly returns False for all advisory messages.

The advisory flag is only set when the ActiveMQDestination(name) constructor is used - but the ActiveMQTopicMarshaller.CreateObject method uses the ActiveMQDestination() constructor so the flag is never set.

The attached patch sets the advisory flag when the PhysicalName setter is called which fixes the problem.




-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/activemq/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] Resolved: (AMQ-1037) IsAdvisory method of ActiveMQDestination incorrectly returns False for Advisory messages

Posted by "Jonas Lim (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/activemq/browse/AMQ-1037?page=all ]

Jonas Lim resolved AMQ-1037.
----------------------------

    Fix Version/s: 4.1.2
       Resolution: Fixed

Thanks! 

patch applied at  https://svn.apache.org/repos/asf/incubator/activemq/activemq-dotnet/trunk/   :

trunk : r477581      

> IsAdvisory method of ActiveMQDestination incorrectly returns False for Advisory messages
> ----------------------------------------------------------------------------------------
>
>                 Key: AMQ-1037
>                 URL: https://issues.apache.org/activemq/browse/AMQ-1037
>             Project: ActiveMQ
>          Issue Type: Bug
>          Components: NMS (C# client)
>    Affects Versions: 4.x
>         Environment: Using latest SVN checkout of DotNetClient
>            Reporter: Stuart Bain
>            Priority: Minor
>             Fix For: 4.1.2
>
>         Attachments: ActiveMQDestination.patch
>
>
> The IsAdvisory method of the ActiveMQDestination class incorrectly returns False for all advisory messages.
> The advisory flag is only set when the ActiveMQDestination(name) constructor is used - but the ActiveMQTopicMarshaller.CreateObject method uses the ActiveMQDestination() constructor so the flag is never set.
> The attached patch sets the advisory flag when the PhysicalName setter is called which fixes the problem.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/activemq/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira