[GitHub] [hudi] MrSleeping123 commented on a change in pull request #4786: [HUDI-3383] Sync column comments while syncing a hive table, especially using spark datasource

[GitBox <gi...@apache.org>]

MrSleeping123 commented on a change in pull request #4786:
URL: https://github.com/apache/hudi/pull/4786#discussion_r817679041



##########
File path: hudi-sync/hudi-hive-sync/src/main/java/org/apache/hudi/hive/ddl/HMSDDLExecutor.java
##########
@@ -247,6 +248,26 @@ public void dropPartitionsToTable(String tableName, List<String> partitionsToDro
     }
   }
 
+  @Override
+  public void updateTableComments(String tableName, Map<String, ImmutablePair<String,String>> alterSchema) {
+    try {
+      Table table = client.getTable(syncConfig.databaseName, tableName);
+      StorageDescriptor sd = table.getSd();
+      for (FieldSchema fieldSchema : sd.getCols()) {

Review comment:
       `StorageDescriptor sd = new StorageDescriptor (table.getSd());`
   like this?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org