You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/05/09 01:46:33 UTC

[GitHub] [dolphinscheduler] kezhenxu94 commented on a diff in pull request #9944: Clean up unused dependencies and packaging issues

kezhenxu94 commented on code in PR #9944:
URL: https://github.com/apache/dolphinscheduler/pull/9944#discussion_r867579354


##########
dolphinscheduler-master/pom.xml:
##########
@@ -67,11 +71,24 @@
                 </exclusion>
             </exclusions>
         </dependency>
-
         <dependency>
             <groupId>org.codehaus.janino</groupId>
             <artifactId>janino</artifactId>
         </dependency>
+        <dependency>
+            <groupId>org.apache.hadoop</groupId>
+            <artifactId>hadoop-common</artifactId>
+            <exclusions>
+                <exclusion>
+                    <groupId>*</groupId>

Review Comment:
   > Is it still need to import this jar package with exclusion *?
   
   Master component only uses the class `ThreadUtil` in `Hadoop-common` itself, nothing in its transitive dependencies is used. note exclusion * only excludes everything `Hadoop-common` brings, not including `Hadoop-common` itself



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org