[GitHub] szha commented on a change in pull request #12468: [MXNET-807] Support integer label type in ctc_loss operator

[GitBox <gi...@apache.org>]

szha commented on a change in pull request #12468: [MXNET-807] Support integer label type in ctc_loss operator
URL: https://github.com/apache/incubator-mxnet/pull/12468#discussion_r215712335
 
 

 ##########
 File path: src/operator/contrib/ctc_loss-inl.h
 ##########
 @@ -50,11 +50,10 @@
 
 namespace mxnet {
 namespace op {
-
 namespace ctc_loss {
-enum CTCLossOpInputs { kData, kLabel };
-enum CTCLossOpOutputs { kOut, kGrad };
-enum CTCLossOpForwardResource { kTempSpace };
+  enum CTCLossOpInputs { kData, kLabel };
+  enum CTCLossOpOutputs { kOut, kGrad };
+  enum CTCLossOpForwardResource { kTempSpace };
 
 Review comment:
   which case does this part fall into? how were we able to check it in without breaking master build if it's either of the cases?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services