[impala] 03/04: IMPALA-8119: document how to set heap size in docker

[ta...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

tarmstrong pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/impala.git

commit 28d5a8299c27fd06779e108943a9aa128c5af15f
Author: Tim Armstrong <ta...@cloudera.com>
AuthorDate: Thu Apr 25 10:43:49 2019 -0700

    IMPALA-8119: document how to set heap size in docker
    
    JAVA_TOOL_OPTIONS is a standard mechanism to pass arguments to a JVM.
    Let's just document this as the canonical way to pass in the heap size.
    
    Change-Id: Ie6ddba3c42a698b52d7c4e2ff6a9c73068e198b2
    Reviewed-on: http://gerrit.cloudera.org:8080/13119
    Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
    Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
 bin/start-impala-cluster.py | 1 -
 docker/README.md            | 9 +++++----
 docker/daemon_entrypoint.sh | 8 ++++----
 3 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/bin/start-impala-cluster.py b/bin/start-impala-cluster.py
index 7b22df5..47193fb 100755
--- a/bin/start-impala-cluster.py
+++ b/bin/start-impala-cluster.py
@@ -528,7 +528,6 @@ class DockerMiniClusterOperations(object):
                    for src, dst in port_map.iteritems()]
     # Impersonate the current user for operations against the minicluster. This is
     # necessary because the user name inside the container is "root".
-    # TODO: pass in the actual options
     env_args = ["-e", "HADOOP_USER_NAME={0}".format(getpass.getuser()),
                 "-e", "JAVA_TOOL_OPTIONS={0}".format(
                     build_java_tool_options(DEFAULT_IMPALAD_JVM_DEBUG_PORT))]
diff --git a/docker/README.md b/docker/README.md
index 5f24032..210b733 100644
--- a/docker/README.md
+++ b/docker/README.md
@@ -4,7 +4,8 @@
 containers, parallelizing the test execution across test suites. See that file
 for more details.
 
-This also contains **experimental** infrastructure to build `impala_base`,
-`catalogd`, `impalad` and `statestored` container images from the output of
-an Impala build. The containers can be built via the CMake target docker_images.
-See CMakeLists.txt for the build targets.
+This also contains infrastructure to build `impala_base`, `catalogd`,
+``statestored`, `impalad_coordinator`, `impalad_executor` and
+`impalad_coord_exec` container images from the output of an Impala build.
+The containers can be built via the CMake target docker_images. See
+CMakeLists.txt for the build targets.
diff --git a/docker/daemon_entrypoint.sh b/docker/daemon_entrypoint.sh
index e745745..b6b4ed7 100755
--- a/docker/daemon_entrypoint.sh
+++ b/docker/daemon_entrypoint.sh
@@ -18,10 +18,10 @@
 
 # Wrapper script that runs the command-line provided as its arguments after
 # setting up the environment required for the daemon processes to run.
-
-# Set -x for easy of debugging.
-# TODO: remove to reduce verbosity once things are more stable.
-set -x
+#
+# Supported environment variables:
+# JAVA_TOOL_OPTIONS: additional options passed to any embedded JVMs. Can be used, e.g.
+#                    to set a max heap size with JAVA_TOOL_OPTIONS="-Xmx4g".
 
 export IMPALA_HOME=/opt/impala