You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/03/18 09:53:52 UTC

[GitHub] [dolphinscheduler] SbloodyS commented on a change in pull request #8987: [Fix][UI Next][V1.0.0-Alpha] Fix the state column of task instance ta…

SbloodyS commented on a change in pull request #8987:
URL: https://github.com/apache/dolphinscheduler/pull/8987#discussion_r829847594



##########
File path: dolphinscheduler-ui-next/src/views/projects/workflow/instance/use-table.ts
##########
@@ -95,45 +93,7 @@ export function useTable() {
         title: t('project.workflow.status'),
         key: 'state',
         className: 'workflow-status',
-        render: (_row: IWorkflowInstance) => {
-          const stateIcon = taskStateIcon[_row.state]
-          const iconElement = h(
-            NIcon,
-            {
-              size: '18px',
-              style: 'position: relative; top: 7.5px; left: 7.5px',
-              class: stateIcon.classNames

Review comment:
       The ```WorkflowE2ETest``` using class ```success``` to verify the process instance success state. Remove it would lead to the ```WorkflowE2ETest``` failed.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org