You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hive.apache.org by st...@apache.org on 2018/03/19 15:52:10 UTC

hive git commit: HIVE-18342: Remove LinkedList from HiveAlterHandler.java (BELUGA BEHR, reviewed by Sahil Takiar)

Repository: hive
Updated Branches:
  refs/heads/master d30d37dbc -> b7c1aa63b


HIVE-18342: Remove LinkedList from HiveAlterHandler.java (BELUGA BEHR, reviewed by Sahil Takiar)


Project: http://git-wip-us.apache.org/repos/asf/hive/repo
Commit: http://git-wip-us.apache.org/repos/asf/hive/commit/b7c1aa63
Tree: http://git-wip-us.apache.org/repos/asf/hive/tree/b7c1aa63
Diff: http://git-wip-us.apache.org/repos/asf/hive/diff/b7c1aa63

Branch: refs/heads/master
Commit: b7c1aa63b989f7d9a7fdda20e45ef991d9c5298b
Parents: d30d37d
Author: BELUGA BEHR <da...@gmail.com>
Authored: Mon Mar 19 08:51:53 2018 -0700
Committer: Sahil Takiar <st...@cloudera.com>
Committed: Mon Mar 19 08:51:53 2018 -0700

----------------------------------------------------------------------
 .../org/apache/hadoop/hive/metastore/HiveAlterHandler.java   | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/hive/blob/b7c1aa63/standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java
----------------------------------------------------------------------
diff --git a/standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java b/standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java
index 0dd3eb1..04828e5 100644
--- a/standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java
+++ b/standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java
@@ -57,7 +57,6 @@ import java.net.URI;
 import java.util.ArrayList;
 import java.util.HashMap;
 import java.util.Iterator;
-import java.util.LinkedList;
 import java.util.List;
 import java.util.Map;
 import java.util.Map.Entry;
@@ -272,9 +271,10 @@ public class HiveAlterHandler implements AlterHandler {
             while (partsToProcess > 0) {
               int batchEnd = Math.min(batchStart + partitionBatchSize, parts.size());
               List<Partition> partBatch = parts.subList(batchStart, batchEnd);
-              partsToProcess -= partBatch.size();
-              batchStart += partBatch.size();
-              List<List<String>> partValues = new LinkedList<>();
+              int partBatchSize = partBatch.size();
+              partsToProcess -= partBatchSize;
+              batchStart += partBatchSize;
+              List<List<String>> partValues = new ArrayList<>(partBatchSize);
               for (Partition part : partBatch) {
                 partValues.add(part.getValues());
               }