You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avro.apache.org by "Bruce Mitchener (JIRA)" <ji...@apache.org> on 2010/03/02 19:01:28 UTC
[jira] Created: (AVRO-445) avro_size_data() to pre-calculate the
size of an avro_datum_t in serialized form
avro_size_data() to pre-calculate the size of an avro_datum_t in serialized form
--------------------------------------------------------------------------------
Key: AVRO-445
URL: https://issues.apache.org/jira/browse/AVRO-445
Project: Avro
Issue Type: New Feature
Components: c
Affects Versions: 1.3.0
Reporter: Bruce Mitchener
Attachments: avro_size.diff
I would like to be able to find out how much buffer space will be required to serialize a given avro_datum_t ... I've started implementing this but wanted to get feedback on the general approach and API.
The details of most of the functions in datum_size.c haven't been updated yet in the attached patch. The rest should be close to working though.
The main point of concern that I have at the moment is that I'm returning an int64_t which, if positive, is the length required and if negative, will be an error condition (like -EINVAL).
Thoughts? Anything else in the attached patch that should change?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (AVRO-445) avro_size_data() to pre-calculate the
size of an avro_datum_t in serialized form
Posted by "Bruce Mitchener (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AVRO-445?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bruce Mitchener updated AVRO-445:
---------------------------------
Attachment: (was: avro_size.diff)
> avro_size_data() to pre-calculate the size of an avro_datum_t in serialized form
> --------------------------------------------------------------------------------
>
> Key: AVRO-445
> URL: https://issues.apache.org/jira/browse/AVRO-445
> Project: Avro
> Issue Type: New Feature
> Components: c
> Affects Versions: 1.3.0
> Reporter: Bruce Mitchener
> Attachments: avro_size.diff
>
>
> I would like to be able to find out how much buffer space will be required to serialize a given avro_datum_t ... I've started implementing this but wanted to get feedback on the general approach and API.
> The details of most of the functions in datum_size.c haven't been updated yet in the attached patch. The rest should be close to working though.
> The main point of concern that I have at the moment is that I'm returning an int64_t which, if positive, is the length required and if negative, will be an error condition (like -EINVAL).
> Thoughts? Anything else in the attached patch that should change?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (AVRO-445) avro_size_data() to pre-calculate the
size of an avro_datum_t in serialized form
Posted by "Bruce Mitchener (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AVRO-445?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bruce Mitchener updated AVRO-445:
---------------------------------
Attachment: avro_size.diff
Attached patch appears to work and includes tests.
> avro_size_data() to pre-calculate the size of an avro_datum_t in serialized form
> --------------------------------------------------------------------------------
>
> Key: AVRO-445
> URL: https://issues.apache.org/jira/browse/AVRO-445
> Project: Avro
> Issue Type: New Feature
> Components: c
> Affects Versions: 1.3.0
> Reporter: Bruce Mitchener
> Attachments: avro_size.diff, avro_size.diff
>
>
> I would like to be able to find out how much buffer space will be required to serialize a given avro_datum_t ... I've started implementing this but wanted to get feedback on the general approach and API.
> The details of most of the functions in datum_size.c haven't been updated yet in the attached patch. The rest should be close to working though.
> The main point of concern that I have at the moment is that I'm returning an int64_t which, if positive, is the length required and if negative, will be an error condition (like -EINVAL).
> Thoughts? Anything else in the attached patch that should change?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (AVRO-445) avro_size_data() to pre-calculate the
size of an avro_datum_t in serialized form
Posted by "Matt Massie (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AVRO-445?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Matt Massie resolved AVRO-445.
------------------------------
Resolution: Fixed
Thanks for the patch, Bruce. Well written with tests. Nice. Committed to trunk.
> avro_size_data() to pre-calculate the size of an avro_datum_t in serialized form
> --------------------------------------------------------------------------------
>
> Key: AVRO-445
> URL: https://issues.apache.org/jira/browse/AVRO-445
> Project: Avro
> Issue Type: New Feature
> Components: c
> Affects Versions: 1.3.0
> Reporter: Bruce Mitchener
> Assignee: Matt Massie
> Attachments: avro_size.diff
>
>
> I would like to be able to find out how much buffer space will be required to serialize a given avro_datum_t ... I've started implementing this but wanted to get feedback on the general approach and API.
> The details of most of the functions in datum_size.c haven't been updated yet in the attached patch. The rest should be close to working though.
> The main point of concern that I have at the moment is that I'm returning an int64_t which, if positive, is the length required and if negative, will be an error condition (like -EINVAL).
> Thoughts? Anything else in the attached patch that should change?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (AVRO-445) avro_size_data() to pre-calculate the
size of an avro_datum_t in serialized form
Posted by "Bruce Mitchener (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AVRO-445?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bruce Mitchener updated AVRO-445:
---------------------------------
Attachment: avro_size.diff
Work in progress...
> avro_size_data() to pre-calculate the size of an avro_datum_t in serialized form
> --------------------------------------------------------------------------------
>
> Key: AVRO-445
> URL: https://issues.apache.org/jira/browse/AVRO-445
> Project: Avro
> Issue Type: New Feature
> Components: c
> Affects Versions: 1.3.0
> Reporter: Bruce Mitchener
> Attachments: avro_size.diff
>
>
> I would like to be able to find out how much buffer space will be required to serialize a given avro_datum_t ... I've started implementing this but wanted to get feedback on the general approach and API.
> The details of most of the functions in datum_size.c haven't been updated yet in the attached patch. The rest should be close to working though.
> The main point of concern that I have at the moment is that I'm returning an int64_t which, if positive, is the length required and if negative, will be an error condition (like -EINVAL).
> Thoughts? Anything else in the attached patch that should change?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
Re: [jira] Assigned: (AVRO-445) avro_size_data() to pre-calculate the size of an avro_datum_t in serialized form
Posted by Doug Cutting <cu...@apache.org>.
Assignee should be the primary author of the patch, Bruce in this case.
Doug
[Sent from mobile]
On Mar 3, 2010, at 6:17 PM, "Matt Massie (JIRA)" <ji...@apache.org>
wrote:
>
> [ https://issues.apache.org/jira/browse/AVRO-445?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
> ]
>
> Matt Massie reassigned AVRO-445:
> --------------------------------
>
> Assignee: Matt Massie
>
>> avro_size_data() to pre-calculate the size of an avro_datum_t in
>> serialized form
>> ---
>> ---
>> ---
>> ---
>> --------------------------------------------------------------------
>>
>> Key: AVRO-445
>> URL: https://issues.apache.org/jira/browse/AVRO-445
>> Project: Avro
>> Issue Type: New Feature
>> Components: c
>> Affects Versions: 1.3.0
>> Reporter: Bruce Mitchener
>> Assignee: Matt Massie
>> Attachments: avro_size.diff
>>
>>
>> I would like to be able to find out how much buffer space will be
>> required to serialize a given avro_datum_t ... I've started
>> implementing this but wanted to get feedback on the general
>> approach and API.
>> The details of most of the functions in datum_size.c haven't been
>> updated yet in the attached patch. The rest should be close to
>> working though.
>> The main point of concern that I have at the moment is that I'm
>> returning an int64_t which, if positive, is the length required and
>> if negative, will be an error condition (like -EINVAL).
>> Thoughts? Anything else in the attached patch that should change?
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>
[jira] Assigned: (AVRO-445) avro_size_data() to pre-calculate the
size of an avro_datum_t in serialized form
Posted by "Matt Massie (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AVRO-445?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Matt Massie reassigned AVRO-445:
--------------------------------
Assignee: Matt Massie
> avro_size_data() to pre-calculate the size of an avro_datum_t in serialized form
> --------------------------------------------------------------------------------
>
> Key: AVRO-445
> URL: https://issues.apache.org/jira/browse/AVRO-445
> Project: Avro
> Issue Type: New Feature
> Components: c
> Affects Versions: 1.3.0
> Reporter: Bruce Mitchener
> Assignee: Matt Massie
> Attachments: avro_size.diff
>
>
> I would like to be able to find out how much buffer space will be required to serialize a given avro_datum_t ... I've started implementing this but wanted to get feedback on the general approach and API.
> The details of most of the functions in datum_size.c haven't been updated yet in the attached patch. The rest should be close to working though.
> The main point of concern that I have at the moment is that I'm returning an int64_t which, if positive, is the length required and if negative, will be an error condition (like -EINVAL).
> Thoughts? Anything else in the attached patch that should change?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (AVRO-445) avro_size_data() to pre-calculate the
size of an avro_datum_t in serialized form
Posted by "Matt Massie (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AVRO-445?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Matt Massie updated AVRO-445:
-----------------------------
Assignee: (was: Matt Massie)
> avro_size_data() to pre-calculate the size of an avro_datum_t in serialized form
> --------------------------------------------------------------------------------
>
> Key: AVRO-445
> URL: https://issues.apache.org/jira/browse/AVRO-445
> Project: Avro
> Issue Type: New Feature
> Components: c
> Affects Versions: 1.3.0
> Reporter: Bruce Mitchener
> Attachments: avro_size.diff
>
>
> I would like to be able to find out how much buffer space will be required to serialize a given avro_datum_t ... I've started implementing this but wanted to get feedback on the general approach and API.
> The details of most of the functions in datum_size.c haven't been updated yet in the attached patch. The rest should be close to working though.
> The main point of concern that I have at the moment is that I'm returning an int64_t which, if positive, is the length required and if negative, will be an error condition (like -EINVAL).
> Thoughts? Anything else in the attached patch that should change?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.