[GitHub] [incubator-superset] rusackas commented on a change in pull request #11389: refactor: Replace react-bootstrap Modals with Antd in Explore

[GitBox <gi...@apache.org>]

rusackas commented on a change in pull request #11389:
URL: https://github.com/apache/incubator-superset/pull/11389#discussion_r513004520



##########
File path: superset-frontend/src/common/components/Modal.tsx
##########
@@ -94,11 +108,13 @@ export default function Modal({
   disablePrimaryButton = false,
   onHide,
   onHandledPrimaryAction,
-  primaryButtonName,
+  primaryButtonName = 'OK',

Review comment:
       ```suggestion
     primaryButtonName = t('OK'),
   ```
   I'm having a _deja vu_ looking at some of this code... maybe this PR needs a rebase?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org