You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/11/17 13:07:31 UTC

[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #2282: cxd56: add initial audio SRC implementation

patacongo commented on a change in pull request #2282:
URL: https://github.com/apache/incubator-nuttx/pull/2282#discussion_r525138881



##########
File path: drivers/audio/cxd56_src.c
##########
@@ -0,0 +1,606 @@
+/****************************************************************************
+ * drivers/audio/cxd56_src.c
+ *
+ *   Copyright 2020 Sony Semiconductor Solutions Corporation

Review comment:
       
   > @btashton they will all be migrated to Apache once SGA is in place.
   
   For all other PRs, we have insisted that the Apache license be in place prior to bringing the code into the repository.  I don't doubt for a minute that the headers will be updated if/when the SGA is in place.  But we need  apply this rule consistently to all code.
   
   Perhaps we need to clarification?  Perhaps we should wait until the SGA is in place?
   
   @justinmclean Do you have any guidance on this?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org