[GitHub] [skywalking] kezhenxu94 commented on a diff in pull request #10382: Migrate tests from junit 4 to junit 5

["kezhenxu94 (via GitHub)" <gi...@apache.org>]

kezhenxu94 commented on code in PR #10382:
URL: https://github.com/apache/skywalking/pull/10382#discussion_r1104154979


##########
pom.xml:
##########
@@ -33,6 +33,10 @@
 
     <modules>
         <module>apm-protocol</module>
+        <module>oap-server</module>
+        <module>oap-server-bom</module>
+        <module>apm-webapp</module>
+        <module>apm-dist</module>

Review Comment:
   > This is the reason we could close `activeByDefault` for those modules, right?
   
   Yes, and because these modules are added in the previous default profiles, so I think this is OK we just make it default here



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org