You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2020/07/20 12:36:05 UTC

[GitHub] [maven-shared-utils] elharo opened a new pull request #58: remove call to deprecated method

elharo opened a new pull request #58:
URL: https://github.com/apache/maven-shared-utils/pull/58


   @dennisl 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [maven-shared-utils] pzygielo commented on a change in pull request #58: remove call to deprecated method

Posted by GitBox <gi...@apache.org>.
pzygielo commented on a change in pull request #58:
URL: https://github.com/apache/maven-shared-utils/pull/58#discussion_r469746624



##########
File path: src/main/java/org/apache/maven/shared/utils/xml/Xpp3DomBuilder.java
##########
@@ -95,10 +94,10 @@ public static Xpp3Dom build( @WillClose InputStream is, @Nonnull String encoding
      * @return the built dom
      * @throws XmlPullParserException in case of an error
      */
-    public static Xpp3Dom build( @WillClose Reader reader, boolean trim )
+    public static Xpp3Dom build( @WillClose Reader in, boolean trim )

Review comment:
       @param not updated




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [maven-shared-utils] elharo merged pull request #58: remove call to deprecated method

Posted by GitBox <gi...@apache.org>.
elharo merged pull request #58:
URL: https://github.com/apache/maven-shared-utils/pull/58


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org