You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "Gary D. Gregory (JIRA)" <ji...@apache.org> on 2012/05/31 13:59:23 UTC
[jira] [Commented] (VFS-419) JarFileSystem incorrectly resolves
file if it has been removed from the cache
[ https://issues.apache.org/jira/browse/VFS-419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13286506#comment-13286506 ]
Gary D. Gregory commented on VFS-419:
-------------------------------------
It seems our unit tests are lacking in this area :(
My first impression is that implementing this should be sufficient:
{code:java}
@Override
protected FileObject createFile(AbstractFileName name) throws FileSystemException
{
return new JarFileObject(name, null, this, false);
}
{code}
All other implementations of createFile(AbstractFileName) follow this pattern.
Can you demonstrate otherwise? In a unit test :)
Gary
> JarFileSystem incorrectly resolves file if it has been removed from the cache
> -----------------------------------------------------------------------------
>
> Key: VFS-419
> URL: https://issues.apache.org/jira/browse/VFS-419
> Project: Commons VFS
> Issue Type: Bug
> Affects Versions: 2.0
> Reporter: Sergey Grigorev
> Labels: core, patch
> Fix For: 2.0
>
> Attachments: JarFileSystem.java.patch
>
> Original Estimate: 0.5h
> Remaining Estimate: 0.5h
>
> If I call fileSystemManager.resolveFile("jar: ... ") and the file was removed from cache, JarFileSystem calls method createFile(AbstractFileName name). This method is not overridden from ZipFileManager and works wrong (its return ZipFileObject instead JarFileObject). But i can override it and make return JarFileObject case this object won't have children and JarURLConnectionImpl won't work. It should reinvalidate cache and return the object with children objects.
> I've added a patch to fix this problem.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira