You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2018/03/06 11:32:01 UTC
[GitHub] ustcweizhou commented on a change in pull request #2476: CLOUDSTACK-10317: Fix SNAT rules for additional public nics
ustcweizhou commented on a change in pull request #2476: CLOUDSTACK-10317: Fix SNAT rules for additional public nics
URL: https://github.com/apache/cloudstack/pull/2476#discussion_r172464559
##########
File path: systemvm/debian/opt/cloud/bin/cs/CsAddress.py
##########
@@ -388,7 +388,7 @@ def fw_router(self):
self.fw.append(["mangle", "",
"-A VPN_%s -j RETURN" % self.address['public_ip']])
self.fw.append(["nat", "",
- "-A POSTROUTING -o eth2 -j SNAT --to-source %s" % self.address['public_ip']])
+ "-A POSTROUTING -o %s -j SNAT --to-source %s" % (self.dev, self.address['public_ip'])])
Review comment:
@rhtyd what we are using are
```
diff --git a/systemvm/patches/debian/config/opt/cloud/bin/cs/CsAddress.py b/systemvm/patches/debian/config/opt/cloud/bin/cs/CsAddress.py
index e6aea26..d336e0a 100755
--- a/systemvm/patches/debian/config/opt/cloud/bin/cs/CsAddress.py
+++ b/systemvm/patches/debian/config/opt/cloud/bin/cs/CsAddress.py
@@ -400,7 +400,7 @@ class CsIP:
self.fw.append(["mangle", "",
"-A VPN_%s -j RETURN" % self.address['public_ip']])
self.fw.append(["nat", "",
- "-A POSTROUTING -o eth2 -j SNAT --to-source %s" % self.address['public_ip']])
+ "-A POSTROUTING -o %s -j SNAT --to-source %s" % (self.dev, self.cl.get_eth2_ip())])
self.fw.append(["mangle", "",
"-A PREROUTING -i %s -m state --state NEW " % self.dev +
"-j CONNMARK --set-xmark %s/0xffffffff" % self.dnum])
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services