You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@activemq.apache.org by "Federico Valeri (Jira)" <ji...@apache.org> on 2020/03/26 08:46:00 UTC

[jira] [Commented] (ARTEMIS-2682) OpenWireMessageConverter refactoring

    [ https://issues.apache.org/jira/browse/ARTEMIS-2682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17067504#comment-17067504 ] 

Federico Valeri commented on ARTEMIS-2682:
------------------------------------------

PR: https://github.com/apache/activemq-artemis/pull/3043

> OpenWireMessageConverter refactoring
> ------------------------------------
>
>                 Key: ARTEMIS-2682
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-2682
>             Project: ActiveMQ Artemis
>          Issue Type: Improvement
>          Components: OpenWire
>    Affects Versions: 2.12.0
>            Reporter: Federico Valeri
>            Priority: Minor
>
> I'm proposing the OpenWireMessageConverter refactoring to have a similar layout as the AMQPConverter. The latter has two dedicated classes for inbound and outbound messages with a singleton entry point for the converter. This change is basically doing the same without semantics change and also adding a unit test for the converter. I'm also eliminating some duplicated code, but the bulk of the code remains untouched.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)