You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by tedyu <gi...@git.apache.org> on 2016/01/29 05:49:59 UTC
[GitHub] flink pull request: FLINK-3301 Ineffective synchronization in Mess...
GitHub user tedyu opened a pull request:
https://github.com/apache/flink/pull/1560
FLINK-3301 Ineffective synchronization in MessageAcknowledgingSourceBase#restoreState
This PR changes synchronization on pendingCheckpoints to this (MessageAcknowledgingSourceBase)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tedyu/flink master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/1560.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1560
----
commit 18338c7c51c3f1ada3541ee988c8028d3a87d38a
Author: tedyu <yu...@gmail.com>
Date: 2016-01-29T04:47:24Z
FLINK-3301 Ineffective synchronization in MessageAcknowledgingSourceBase#restoreState
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: FLINK-3301 Ineffective synchronization in Mess...
Posted by mxm <gi...@git.apache.org>.
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/1560#discussion_r51408033
--- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/source/MessageAcknowledgingSourceBase.java ---
@@ -177,21 +177,19 @@ protected boolean addId(UId uid) {
}
@Override
- public void restoreState(SerializedCheckpointData[] state) throws Exception {
--- End diff --
You should consider pulling the latest master version then.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: FLINK-3301 Ineffective synchronization in Mess...
Posted by ramkrish86 <gi...@git.apache.org>.
Github user ramkrish86 commented on a diff in the pull request:
https://github.com/apache/flink/pull/1560#discussion_r51240892
--- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/source/MessageAcknowledgingSourceBase.java ---
@@ -177,21 +177,19 @@ protected boolean addId(UId uid) {
}
@Override
- public void restoreState(SerializedCheckpointData[] state) throws Exception {
--- End diff --
Some how in my version of the code am not seeing this synchronization at all on pendingCheckpoints.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: FLINK-3301 Ineffective synchronization in Mess...
Posted by mxm <gi...@git.apache.org>.
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/1560#issuecomment-178029684
Thanks for the pull request. The issue has been identified in the meantime. It is only a testing issue and not a synchronization issue in the RMQSource.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: FLINK-3301 Ineffective synchronization in Mess...
Posted by tedyu <gi...@git.apache.org>.
Github user tedyu closed the pull request at:
https://github.com/apache/flink/pull/1560
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---