DO NOT REPLY [Bug 23323] New: - VSS task uses SSDIR environment variable instead of serverPath parameter

[bu...@apache.org]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://nagoya.apache.org/bugzilla/show_bug.cgi?id=23323>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=23323

VSS task uses SSDIR environment variable instead of serverPath parameter

           Summary: VSS task uses SSDIR environment variable instead of
                    serverPath parameter
           Product: Ant
           Version: 1.5.3
          Platform: PC
        OS/Version: Windows NT/2K
            Status: NEW
          Severity: Normal
          Priority: Other
         Component: Optional Tasks
        AssignedTo: dev@ant.apache.org
        ReportedBy: chienbd@fsoft.com.vn


I have a SSDIR environment variable. And when I perform VSS task, VSS task uses 
SSDIR environment variable instead of serverPath parameter. I saw 
org.apache.tools.ant.taskdefs.optional.vss.MSVSS.java and found some command in 
run method:
    protected int run(Commandline cmd) {
        try {
            Execute exe = new Execute(new LogStreamHandler(this,
                                                           Project.MSG_INFO,
                                                           Project.MSG_WARN));

            // If location of ss.ini is specified we need to set the
            // environment-variable SSDIR to this value
            if (m_serverPath != null) {
                String[] env = exe.getEnvironment();
                if (env == null) {
                    env = new String[0];
                }
                String[] newEnv = new String[env.length + 1];
*************************
------->        for (int i = 0; i < env.length ; i++) {
------->            newEnv[i] = env[i];
------->        }
------->        newEnv[env.length] = "SSDIR=" + m_serverPath;
I think should change to
                for (int i = 0; i < env.length ; i++) {
                    newEnv[i + 1] = env[i];
                }
                newEnv[0] = "SSDIR=" + m_serverPath;

***************************
                exe.setEnvironment(newEnv);
            }

            exe.setAntRun(project);
            exe.setWorkingDirectory(project.getBaseDir());
            exe.setCommandline(cmd.getCommandline());
            return exe.execute();
        } catch (java.io.IOException e) {
            throw new BuildException(e, location);
        }
    }

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org