You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/08/17 15:18:20 UTC
[GitHub] [pulsar] nicoloboschi opened a new pull request, #17147: [fix][test] Fix flaky test TopicReaderTest.testMultiReaderIsAbleToSeekWithTimeOnMiddleOfTopic
nicoloboschi opened a new pull request, #17147:
URL: https://github.com/apache/pulsar/pull/17147
### Motivation
Sometimes this test fails with
```
java.lang.AssertionError: Received duplicate message msg num 5 expected [true] but found [false]
at org.testng.Assert.fail(Assert.java:99)
at org.testng.Assert.failNotEquals(Assert.java:1037)
at org.testng.Assert.assertTrue(Assert.java:45)
at org.apache.pulsar.client.api.TopicReaderTest.testMultiReaderIsAbleToSeekWithTimeOnMiddleOfTopic(TopicReaderTest.java:1404)
```
This is because while the reader tries to seek to a fixed position, the dispatcher have already sent messages starting from the Earliest position.
Even if the consumer on the client side empties the incoming messages after the cursor reset, the messages may already be on the client side and not enqued yet. I think this is a little defeat of the seek feature
### Modifications
* Test seek() resetting the cursor before the current position (Latest) and improved the test checks
- [x] `doc-not-needed`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] nicoloboschi commented on pull request #17147: [fix][test] Fix flaky test TopicReaderTest.testMultiReaderIsAbleToSeekWithTimeOnMiddleOfTopic
Posted by GitBox <gi...@apache.org>.
nicoloboschi commented on PR #17147:
URL: https://github.com/apache/pulsar/pull/17147#issuecomment-1225451084
OK great, didn't notice that pull, will close this pull
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] mattisonchao commented on pull request #17147: [fix][test] Fix flaky test TopicReaderTest.testMultiReaderIsAbleToSeekWithTimeOnMiddleOfTopic
Posted by GitBox <gi...@apache.org>.
mattisonchao commented on PR #17147:
URL: https://github.com/apache/pulsar/pull/17147#issuecomment-1225439672
I think it is not the test problem. maybe we can try to fix the seek operation.
FYI: https://github.com/apache/pulsar/issues/16757#issuecomment-1212366343
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] nicoloboschi closed pull request #17147: [fix][test] Fix flaky test TopicReaderTest.testMultiReaderIsAbleToSeekWithTimeOnMiddleOfTopic
Posted by GitBox <gi...@apache.org>.
nicoloboschi closed pull request #17147: [fix][test] Fix flaky test TopicReaderTest.testMultiReaderIsAbleToSeekWithTimeOnMiddleOfTopic
URL: https://github.com/apache/pulsar/pull/17147
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org