You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/07/04 11:55:35 UTC
[GitHub] [pulsar] RobertIndie opened a new pull request, #16369: [fix][doc] Enable zk when starting standalone in pulsar-sql doc
RobertIndie opened a new pull request, #16369:
URL: https://github.com/apache/pulsar/pull/16369
<!--
### Contribution Checklist
- PR title format should be *[type][component] summary*. For details, see *[Guideline - Pulsar PR Naming Convention](https://docs.google.com/document/d/1d8Pw6ZbWk-_pCKdOmdvx9rnhPiyuxwq60_TrD68d7BA/edit#heading=h.trs9rsex3xom)*.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
Master Issue: #16354
### Motivation
After https://github.com/apache/pulsar/pull/15478 gets merged, the zookeeper won't be enabled by default when starting the pulsar standalone. But the pulsar SQL depends on the zookeeper. We need to set`PULSAR_STANDALONE_USE_ZOOKEEPER=1` to enable zookeeper when using the pulsar sql.
### Modifications
* Add `PULSAR_STANDALONE_USE_ZOOKEEPER=1` before running pulsar standalone in pulsar-sql doc
### Documentation
Check the box below or label this PR directly.
Need to update docs?
- [ ] `doc-required`
(Your PR needs to update docs and you will update later)
- [ ] `doc-not-needed`
(Please explain why)
- [x] `doc`
(Your PR contains doc changes)
- [ ] `doc-complete`
(Docs have been already added)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] momo-jun commented on a diff in pull request #16369: [fix][doc] Enable zk when starting standalone in pulsar-sql doc
Posted by GitBox <gi...@apache.org>.
momo-jun commented on code in PR #16369:
URL: https://github.com/apache/pulsar/pull/16369#discussion_r913345396
##########
site2/docs/sql-getting-started.md:
##########
@@ -17,10 +17,17 @@ To query data in Pulsar with Pulsar SQL, complete the following steps.
```bash
-./bin/pulsar standalone
+PULSAR_STANDALONE_USE_ZOOKEEPER=1 ./bin/pulsar standalone
```
+:::note
+
+Starting the Pulsar standalone cluster from scratch doesn't enable zookeeper by default.
Review Comment:
```suggestion
Starting the Pulsar standalone cluster from scratch doesn't enable ZooKeeper by default.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] momo-jun commented on a diff in pull request #16369: [fix][doc] Enable zk when starting standalone in pulsar-sql doc
Posted by GitBox <gi...@apache.org>.
momo-jun commented on code in PR #16369:
URL: https://github.com/apache/pulsar/pull/16369#discussion_r913345640
##########
site2/docs/sql-getting-started.md:
##########
@@ -17,10 +17,17 @@ To query data in Pulsar with Pulsar SQL, complete the following steps.
```bash
-./bin/pulsar standalone
+PULSAR_STANDALONE_USE_ZOOKEEPER=1 ./bin/pulsar standalone
```
+:::note
+
+Starting the Pulsar standalone cluster from scratch doesn't enable zookeeper by default.
+However, the Pulsar SQL depends on the zookeeper. Therefore, we need to set `PULSAR_STANDALONE_USE_ZOOKEEPER=1` to enable the zookeeper.
Review Comment:
```suggestion
However, the Pulsar SQL depends on ZooKeeper. Therefore, you need to set `PULSAR_STANDALONE_USE_ZOOKEEPER=1` to enable ZooKeeper.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Anonymitaet merged pull request #16369: [fix][doc] Enable zk when starting standalone in pulsar-sql doc
Posted by GitBox <gi...@apache.org>.
Anonymitaet merged PR #16369:
URL: https://github.com/apache/pulsar/pull/16369
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Anonymitaet commented on pull request #16369: [fix][doc] Enable zk when starting standalone in pulsar-sql doc
Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on PR #16369:
URL: https://github.com/apache/pulsar/pull/16369#issuecomment-1175040582
Thank you! Looking forward to more contributions! 😊 @RobertIndie
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org