[GitHub] [cloudstack] PaulAngus opened a new pull request #3350: [WIP] Get Diagnostics: Download logs and diagnostics data from SSVM, CPVM, Router

[GitBox <gi...@apache.org>]

PaulAngus opened a new pull request #3350: [WIP] Get Diagnostics: Download logs and diagnostics data from SSVM, CPVM, Router
URL: https://github.com/apache/cloudstack/pull/3350
 
 
   ## Description
   
   This implements a new feature to get logs and diagnostics data from systemvms (CPVM, SSVM) and virtual routers as a downloadable zip file from the secondary storage. The diagnostics zip files live in the `diagnostics` directory of the secondary storage. The feature is only supported for NFS based secondary storage and root admins.
   
   FS: https://cwiki.apache.org/confluence/display/CLOUDSTACK/CloudStack+Get+Diagnostics+Data+API
   
   The feature adds the following global settings:
   ```
   diagnostics.data.gc.enable
   diagnostics.data.gc.interval
   diagnostics.data.retrieval.timeout
   diagnostics.data.max.file.age
   diagnostics.data.disable.threshold
   diagnostics.data.systemvm.defaults
   diagnostics.data.router.defaults
   ```
   
   In the UI, the root admin can now see a download button to get the diagnostics data from CPVM, SSVM and VRs.
   
   ## Types of changes
   <!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
   - [ ] Breaking change (fix or feature that would cause existing functionality to change)
   - [x] New feature (non-breaking change which adds functionality)
   - [ ] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ## Screenshots (if appropriate):
   
   **Download icon in menu:**
   ![image](https://user-images.githubusercontent.com/4810220/58273148-fb332200-7d87-11e9-93ba-b463bf811752.png)
   
   **Prompt to override default files:**
   ![image](https://user-images.githubusercontent.com/4810220/58273201-1b62e100-7d88-11e9-82f9-e68de702230d.png)
   
   **Download link:**
   ![image](https://user-images.githubusercontent.com/4810220/58273236-303f7480-7d88-11e9-8aba-8110f6a26163.png)
   
   **Files in the tarball:**
   ![image](https://user-images.githubusercontent.com/4810220/58273294-4c431600-7d88-11e9-9d30-b9fe8fc466ee.png)
   
   ## How Has This Been Tested?
   <!-- Please describe in detail how you tested your changes. -->
   <!-- Include details of your testing environment, and the tests you ran to -->
   <!-- see how your change affects other areas of the code, etc. -->
   
   Manual testing of downloading diagnostics for VRs, SSVMs and CPVMs
   
   
   <!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document -->
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services