[GitHub] [superset] dpgaspar commented on a change in pull request #12602: feat(db engines): add support for Opendistro Elasticsearch (AWS ES)

[GitBox <gi...@apache.org>]

dpgaspar commented on a change in pull request #12602:
URL: https://github.com/apache/superset/pull/12602#discussion_r573165420



##########
File path: superset/db_engine_specs/elasticsearch.py
##########
@@ -46,3 +46,34 @@ def convert_dttm(cls, target_type: str, dttm: datetime) -> Optional[str]:
         if target_type.upper() == utils.TemporalType.DATETIME:
             return f"""CAST('{dttm.isoformat(timespec="seconds")}' AS DATETIME)"""
         return None
+
+
+class OpenDistroEngineSpec(BaseEngineSpec):  # pylint: disable=abstract-method
+
+    time_groupby_inline = True
+    time_secondary_columns = True
+    allows_joins = False
+    allows_subqueries = True
+
+    _time_grain_expressions = {
+        None: "{col}",
+        "PT1S": "date_format({col}, 'yyyy-MM-dd HH:mm:ss.000')",
+        "PT1M": "date_format({col}, 'yyyy-MM-dd HH:mm:00.000')",
+        "PT1H": "date_format({col}, 'yyyy-MM-dd HH:00:00.000')",
+        "P1D": "date_format({col}, 'yyyy-MM-dd 00:00:00.000')",
+        "P1M": "date_format({col}, 'yyyy-MM-01 00:00:00.000')",
+        "P1Y": "date_format({col}, 'yyyy-01-01 00:00:00.000')",
+    }
+
+    engine = "odelasticsearch"
+    engine_name = "ElasticSearch"
+
+    @classmethod
+    def convert_dttm(cls, target_type: str, dttm: datetime) -> Optional[str]:
+        if target_type.upper() == utils.TemporalType.DATETIME:
+            return f"""'{dttm.isoformat(timespec="seconds")}'"""
+        return None

Review comment:
       To my understanding by default Elasticsearch only supports `date` field type
   
   https://opendistro.github.io/for-elasticsearch-docs/docs/sql/datatypes/#date-and-time-types
   ```
   ...
   By default, the Elasticsearch DSL uses the date type as the only date-time related type that contains all information of an absolute time point.
   ...
   ```
   
   For the SQL endpoint, we can use date functions that will return other date/time types out of them




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org