You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by David Mackey <td...@booleanhaiku.com> on 2013/02/06 05:30:14 UTC
Review Request: Resolve GCC 4.7 unistd.h header dependency change
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9318/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman, Vinod Kone, and Ben Mahler.
Description
-------
GCC 4.7 resolved some namespace polution issues by no longer including
unistd.h in many of the stdlib include files.
- Explicitly include unistd.h to call sleep() and resolve build issue.
This addresses bug MESOS-271.
https://issues.apache.org/jira/browse/MESOS-271
Diffs
-----
src/examples/long_lived_executor.cpp bb38873
Diff: https://reviews.apache.org/r/9318/diff/
Testing
-------
make check passes
Thanks,
David Mackey
Re: Review Request: Resolve GCC 4.7 unistd.h header dependency change
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9318/#review16237
-----------------------------------------------------------
Ship it!
Ship It!
- Ben Mahler
On Feb. 6, 2013, 4:30 a.m., David Mackey wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9318/
> -----------------------------------------------------------
>
> (Updated Feb. 6, 2013, 4:30 a.m.)
>
>
> Review request for mesos, Benjamin Hindman, Vinod Kone, and Ben Mahler.
>
>
> Description
> -------
>
> GCC 4.7 resolved some namespace polution issues by no longer including
> unistd.h in many of the stdlib include files.
>
> - Explicitly include unistd.h to call sleep() and resolve build issue.
>
>
> This addresses bug MESOS-271.
> https://issues.apache.org/jira/browse/MESOS-271
>
>
> Diffs
> -----
>
> src/examples/long_lived_executor.cpp bb38873
>
> Diff: https://reviews.apache.org/r/9318/diff/
>
>
> Testing
> -------
>
> make check passes
>
>
> Thanks,
>
> David Mackey
>
>
Re: Review Request: Resolve GCC 4.7 unistd.h header dependency change
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9318/#review16196
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On Feb. 6, 2013, 4:30 a.m., David Mackey wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9318/
> -----------------------------------------------------------
>
> (Updated Feb. 6, 2013, 4:30 a.m.)
>
>
> Review request for mesos, Benjamin Hindman, Vinod Kone, and Ben Mahler.
>
>
> Description
> -------
>
> GCC 4.7 resolved some namespace polution issues by no longer including
> unistd.h in many of the stdlib include files.
>
> - Explicitly include unistd.h to call sleep() and resolve build issue.
>
>
> This addresses bug MESOS-271.
> https://issues.apache.org/jira/browse/MESOS-271
>
>
> Diffs
> -----
>
> src/examples/long_lived_executor.cpp bb38873
>
> Diff: https://reviews.apache.org/r/9318/diff/
>
>
> Testing
> -------
>
> make check passes
>
>
> Thanks,
>
> David Mackey
>
>