[GitHub] [hbase] Apache9 commented on a change in pull request #1737: HBASE-24382 Flush partial stores of region filtered by seqId when arc…

[GitBox <gi...@apache.org>]

Apache9 commented on a change in pull request #1737:
URL: https://github.com/apache/hbase/pull/1737#discussion_r428404462



##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
##########
@@ -2444,8 +2451,16 @@ public FlushResultImpl flushcache(boolean forceFlushAllStores, boolean writeFlus
       }
 
       try {
-        Collection<HStore> specificStoresToFlush =
+        Collection<HStore> specificStoresToFlush = null;
+        if (!forceFlushAllStores && families != null) {
+          specificStoresToFlush = stores.entrySet().stream()
+            .filter(e -> families.contains(Bytes.toString(e.getKey())))

Review comment:
       If we want to use contains then we better use a Set instead of a List?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org