You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/12/02 08:49:56 UTC

[GitHub] [spark] xinrong-databricks commented on pull request #34774: [SPARK-37516][PYTHON][SQL] Uses Python's standard string formatter for SQL API in PySpark

xinrong-databricks commented on pull request #34774:
URL: https://github.com/apache/spark/pull/34774#issuecomment-984416456


   Looks great! I notice that `kwargs` of both SQLStringFormatter and PandasSQLStringFormatter is of `Mapping[str, Any]`. They seem to accept different types of `kwargs` though. Shall we be more specific about the type, which may also act as documentation? I am also fine with the current typing.
    


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org