You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@buildstream.apache.org by GitBox <gi...@apache.org> on 2021/02/24 19:26:07 UTC
[GitHub] [buildstream] BenjaminSchubert opened a new pull request #1447: Completely remove the pipe between the parent and the child subprocess
BenjaminSchubert opened a new pull request #1447:
URL: https://github.com/apache/buildstream/pull/1447
This will improve messaging between both and remove some contention on IO in the main process.
I have looked at generated log files from the build, and could not spot errors, If someone else could have a look, it would be much appreciated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream] BenjaminSchubert merged pull request #1447: Completely remove the pipe between the parent and the child subprocess
Posted by GitBox <gi...@apache.org>.
BenjaminSchubert merged pull request #1447:
URL: https://github.com/apache/buildstream/pull/1447
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream] gtristan commented on pull request #1447: Completely remove the pipe between the parent and the child subprocess
Posted by GitBox <gi...@apache.org>.
gtristan commented on pull request #1447:
URL: https://github.com/apache/buildstream/pull/1447#issuecomment-789531138
I concur, I stared the patch quite hard in the face and it appears correct to me.
I am still a little curious about how success/fail/error status of child jobs is communicated in the absence of our pipe, but this appears to have all changed in the main previous patch which moves to a threaded scheduler, so it is irrelevant here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream] BenjaminSchubert commented on pull request #1447: Completely remove the pipe between the parent and the child subprocess
Posted by GitBox <gi...@apache.org>.
BenjaminSchubert commented on pull request #1447:
URL: https://github.com/apache/buildstream/pull/1447#issuecomment-789607493
@gtristan
> I am still a little curious about how success/fail/error status of child jobs is communicated in the absence of our pipe, but this appears to have all changed in the main previous patch which moves to a threaded scheduler, so it is irrelevant here.
This is now done by letting exceptions propagate, since we are in the same process :) Indeed changed before.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org