You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "tirkarthi (via GitHub)" <gi...@apache.org> on 2025/01/23 14:16:29 UTC
[PR] Dagrun details page [airflow]
tirkarthi opened a new pull request, #45970:
URL: https://github.com/apache/airflow/pull/45970
Add a details tab similar to task instance details page since the header is missing information like data interval start, data interval end, conf etc. I have ported the `RenderedJsonField` to accept only object with usage limited to `dagrun.conf` which is an object type as per the API. The diff is larger because taskinstance details was using `Run/Details` where run folder is for dagrun related pages. I have moved the taskinstance details code to `TaskInstance/Details` for clarity.
Please let me know if there is a different design for this page.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Dagrun details page [airflow]
Posted by "tirkarthi (via GitHub)" <gi...@apache.org>.
tirkarthi commented on PR #45970:
URL: https://github.com/apache/airflow/pull/45970#issuecomment-2610614800
I would opt for a new tab and not to include it in the task details tab. The rendered templates might need a discussion since the API doesn't return the file extension values and also nested fields as separate which are helpful in syntax highlighting.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Dagrun details page [airflow]
Posted by "jscheffl (via GitHub)" <gi...@apache.org>.
jscheffl commented on PR #45970:
URL: https://github.com/apache/airflow/pull/45970#issuecomment-2610778282
> I would opt for a new tab and not to include it in the task details tab. The rendered templates might need a discussion since the API doesn't return the file extension values and also nested fields as separate which are helpful in syntax highlighting.
Makes sense for me. Also if all is on one page then it is quite long and might render slower.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Dagrun details page [airflow]
Posted by "bbovenzi (via GitHub)" <gi...@apache.org>.
bbovenzi merged PR #45970:
URL: https://github.com/apache/airflow/pull/45970
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org