You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hbase.apache.org by li...@apache.org on 2014/04/10 20:18:35 UTC

svn commit: r1586394 - /hbase/branches/0.89-fb/src/test/java/org/apache/hadoop/hbase/thrift/swift/TestSimpleOperations.java

Author: liyin
Date: Thu Apr 10 18:18:35 2014
New Revision: 1586394

URL: http://svn.apache.org/r1586394
Log:
[master] Remove testSimpleMultiActionUsingHadoopRpc

Author: fan

Summary: Because it's the same with testSimpleMultiActionUsingThrift

Test Plan: TBD

Reviewers: adela, manukranthk, gauravm, daviddeng

Reviewed By: daviddeng

CC: hbase-dev@

Differential Revision: https://phabricator.fb.com/D1268278

Modified:
    hbase/branches/0.89-fb/src/test/java/org/apache/hadoop/hbase/thrift/swift/TestSimpleOperations.java

Modified: hbase/branches/0.89-fb/src/test/java/org/apache/hadoop/hbase/thrift/swift/TestSimpleOperations.java
URL: http://svn.apache.org/viewvc/hbase/branches/0.89-fb/src/test/java/org/apache/hadoop/hbase/thrift/swift/TestSimpleOperations.java?rev=1586394&r1=1586393&r2=1586394&view=diff
==============================================================================
--- hbase/branches/0.89-fb/src/test/java/org/apache/hadoop/hbase/thrift/swift/TestSimpleOperations.java (original)
+++ hbase/branches/0.89-fb/src/test/java/org/apache/hadoop/hbase/thrift/swift/TestSimpleOperations.java Thu Apr 10 18:18:35 2014
@@ -474,7 +474,7 @@ public class TestSimpleOperations {
    * @throws IOException
    */
   @Test
-  public void testSimpleMultiActionUsingThrift() throws IOException {
+  public void testSimpleMultiAction() throws IOException {
     byte[] r1 = Bytes.toBytes("r1");
     byte[] value = Bytes.toBytes("test-value");
     Result[] result;
@@ -487,35 +487,8 @@ public class TestSimpleOperations {
 
     // do a batch get via Thrift
     Get g = new Get.Builder(r1).addFamily(FAMILY).create();
-    List<Get> gets = new ArrayList<Get>();
-    gets.add(g);
-    result = ht.batchGet(gets);
-    LOG.debug("Found the result : " + result);
-    assertTrue(result.length == 1);
-    assertTrue(Bytes.equals(result[0].getValue(FAMILY, null), value));
-  }
-
-  /**
-   * Test if doing batchGet works via hadoop rpc
-   *
-   * @throws IOException
-   */
-  @Test
-  public void testSimpleMultiActionUsingHadoopRpc() throws IOException {
-    byte[] r1 = Bytes.toBytes("r1");
-    byte[] value = Bytes.toBytes("test-value");
-    Result[] result;
-    HTable ht = TEST_UTIL.createTable(TABLE, FAMILIES);
-
-    //do a put via hadoop rpc
-    Put put = new Put(r1);
-    put.add(FAMILY, null, value);
-    ht.put(put);
-
-    Get g = new Get.Builder(r1).addFamily(FAMILY).create();
-    List<Get> gets = new ArrayList<Get>();
+    List<Get> gets = new ArrayList<>();
     gets.add(g);
-    // do a batch get via hadoop rpc
     result = ht.batchGet(gets);
     LOG.debug("Found the result : " + result);
     assertTrue(result.length == 1);