You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/05/25 07:51:24 UTC

[GitHub] [incubator-doris] jackwener opened a new pull request, #9767: [enhancement](style): polish the `checkstyle`

jackwener opened a new pull request, #9767:
URL: https://github.com/apache/incubator-doris/pull/9767

   # Proposed changes
   
   Issue Number: close #xxx
   
   ## Problem Summary:
   
   Describe the overview of changes.
   
   - cancel the auto-align in Javadoc
   
   ```java
   @ param1       desc
   @ paramExample desc
   ``` 
   
   - polish doc for checkstyle
   
   
   ## Checklist(Required)
   
   1. Does it affect the original behavior: (No)
   2. Has unit tests been added: (No)
   3. Has document been added or modified: (yes)
   4. Does it need to update dependencies: (no)
   5. Are there any changes that cannot be rolled back: (No)
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [incubator-doris] adonis0147 commented on pull request #9767: [enhancement](style): polish the `checkstyle`

Posted by GitBox <gi...@apache.org>.
adonis0147 commented on PR #9767:
URL: https://github.com/apache/incubator-doris/pull/9767#issuecomment-1139430472

   Ok, you didn't use the snapshot in the English docs.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [incubator-doris] jackwener commented on pull request #9767: [enhancement](style): polish the `checkstyle`

Posted by GitBox <gi...@apache.org>.
jackwener commented on PR #9767:
URL: https://github.com/apache/incubator-doris/pull/9767#issuecomment-1140435873

   > Better to use English in image.
   
   fixed


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [incubator-doris] jackwener commented on pull request #9767: [enhancement](style): polish the `checkstyle`

Posted by GitBox <gi...@apache.org>.
jackwener commented on PR #9767:
URL: https://github.com/apache/incubator-doris/pull/9767#issuecomment-1139421967

   > Hi @jackwener , would you like to translate the notes in English and use them in snapshot (idea-checkstyle-plugin.png)?
   
   I think it's unnecessary, because English doc is exist.
   
   ![image](https://user-images.githubusercontent.com/30525741/170667298-87a2ad71-ea6b-4e4e-9fff-8d9ee6237df8.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [incubator-doris] adonis0147 commented on pull request #9767: [enhancement](style): polish the `checkstyle`

Posted by GitBox <gi...@apache.org>.
adonis0147 commented on PR #9767:
URL: https://github.com/apache/incubator-doris/pull/9767#issuecomment-1139420175

   Hi @jackwener , would you like to translate the notes in English and use them in snapshot (idea-checkstyle-plugin.png)?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [incubator-doris] adonis0147 commented on pull request #9767: [enhancement](style): polish the `checkstyle`

Posted by GitBox <gi...@apache.org>.
adonis0147 commented on PR #9767:
URL: https://github.com/apache/incubator-doris/pull/9767#issuecomment-1139431200

   LGTM


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [incubator-doris] yiguolei merged pull request #9767: [enhancement](style): polish the `checkstyle`

Posted by GitBox <gi...@apache.org>.
yiguolei merged PR #9767:
URL: https://github.com/apache/incubator-doris/pull/9767


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org