You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/09/20 13:03:01 UTC

[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request, #7140: arch/armv[6|7|8]-m: Change _vectors from uint32_t to const void *

xiaoxiang781216 opened a new pull request, #7140:
URL: https://github.com/apache/incubator-nuttx/pull/7140

   ## Summary
   and move the declaration to arm_internal.h to avoid the duplication
   
   ## Impact
   Code refactor only
   
   ## Testing
   Pass CI
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] pkarashchenko merged pull request #7140: arch: Move _vector and g_current_regs definition to common place

Posted by GitBox <gi...@apache.org>.
pkarashchenko merged PR #7140:
URL: https://github.com/apache/incubator-nuttx/pull/7140


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #7140: arch: Move _vector and g_current_regs definition to common place

Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on code in PR #7140:
URL: https://github.com/apache/incubator-nuttx/pull/7140#discussion_r976128863


##########
boards/arm/imxrt/teensy-4.x/src/imxrt_flexspi_nor_boot.h:
##########
@@ -91,7 +91,7 @@
 
 /* Located in Destination Memory */
 
-#define IMAGE_ENTRY_ADDRESS        ((uint32_t)&_vectors)
+#define IMAGE_ENTRY_ADDRESS        ((uint32_t)_vectors)

Review Comment:
   There is no issue in getting address of an array. Probably this is done to keep style in sync with other places



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #7140: arch/armv[6|7|8]-m: Change _vectors from uint32_t to const void *

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on PR #7140:
URL: https://github.com/apache/incubator-nuttx/pull/7140#issuecomment-1252488421

   Please ignore the false alarm:
   Error: /home/runner/work/incubator-nuttx/incubator-nuttx/nuttx/arch/arm/src/phy62xx/irq.c:197:5: error: Mixed case identifier found


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #7140: arch: Move _vector and g_current_regs definition to common place

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #7140:
URL: https://github.com/apache/incubator-nuttx/pull/7140#discussion_r976587617


##########
boards/arm/imxrt/teensy-4.x/src/imxrt_flexspi_nor_boot.h:
##########
@@ -91,7 +91,7 @@
 
 /* Located in Destination Memory */
 
-#define IMAGE_ENTRY_ADDRESS        ((uint32_t)&_vectors)
+#define IMAGE_ENTRY_ADDRESS        ((uint32_t)_vectors)

Review Comment:
   Yes.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org