You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by ajantha-bhat <gi...@git.apache.org> on 2018/05/14 12:13:54 UTC
[GitHub] carbondata pull request #2306: [CARBONDATA-2479] Multiple issue fixes in SDK...
GitHub user ajantha-bhat opened a pull request:
https://github.com/apache/carbondata/pull/2306
[CARBONDATA-2479] Multiple issue fixes in SDK writer and external table flow
[CARBONDATA-2479] Multiple issues:
fixed external table path display
fixed default value for array in AVRO
fixed NPE when delete folder before the second select query
fixed primetive time stamp sdk load Issue fix
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:
- [ ] Any interfaces changed?NA
- [ ] Any backward compatibility impacted?NA
- [ ] Document update required?NA
- [ ] Testing done
yes updated the UT
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA. NA
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ajantha-bhat/carbondata issue_fix
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/carbondata/pull/2306.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2306
----
commit 2cec0497da785b1c258c9dafbaa52596539335bb
Author: ajantha-bhat <aj...@...>
Date: 2018-05-14T09:58:23Z
[CARBONDATA-2479] Multiple issues:
fixed external table path display
fixed default value for array in AVRO
fixed NPE when delete folder before the second select query
fixed primetive time stamp sdk load Issue fix
----
---
[GitHub] carbondata issue #2306: [CARBONDATA-2479] Multiple issue fixes in SDK writer...
Posted by kunal642 <gi...@git.apache.org>.
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/2306
retest this please
---
[GitHub] carbondata issue #2306: [CARBONDATA-2479] Multiple issue fixes in SDK writer...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2306
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4956/
---
[GitHub] carbondata pull request #2306: [CARBONDATA-2479] Multiple issue fixes in SDK...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/carbondata/pull/2306
---
[GitHub] carbondata issue #2306: [CARBONDATA-2479] Multiple issue fixes in SDK writer...
Posted by ajantha-bhat <gi...@git.apache.org>.
Github user ajantha-bhat commented on the issue:
https://github.com/apache/carbondata/pull/2306
@ravipesala : PR is ready
---
[GitHub] carbondata issue #2306: [CARBONDATA-2479] Multiple issue fixes in SDK writer...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2306
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5881/
---
[GitHub] carbondata issue #2306: [CARBONDATA-2479] Multiple issue fixes in SDK writer...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2306
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4940/
---
[GitHub] carbondata issue #2306: [CARBONDATA-2479] Multiple issue fixes in SDK writer...
Posted by ajantha-bhat <gi...@git.apache.org>.
Github user ajantha-bhat commented on the issue:
https://github.com/apache/carbondata/pull/2306
retest this please
---
[GitHub] carbondata pull request #2306: [CARBONDATA-2479] Multiple issue fixes in SDK...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2306#discussion_r188678446
--- Diff: store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonWriterBuilder.java ---
@@ -540,4 +543,19 @@ private CarbonLoadModel buildLoadModel(CarbonTable table, long UUID, String task
setCsvHeader(build);
return build;
}
+
+ /**
+ * can set the sortScope to NO_SORT
+ *
+ * @param sortScope can be set to "NO_SORT" to avoid sorting during load.
+ * by default sort_scope is "LOCAL_SORT"
+ * @return updated CarbonWriterBuilder
+ */
+ public CarbonWriterBuilder sortScope(String sortScope) {
+ if (!sortScope.equalsIgnoreCase("NO_SORT")) {
--- End diff --
Remove NO_SORT from sdk.
---
[GitHub] carbondata issue #2306: [CARBONDATA-2479] Multiple issue fixes in SDK writer...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2306
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4770/
---
[GitHub] carbondata issue #2306: [CARBONDATA-2479] Multiple issue fixes in SDK writer...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2306
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5874/
---
[GitHub] carbondata issue #2306: [CARBONDATA-2479] Multiple issue fixes in SDK writer...
Posted by ajantha-bhat <gi...@git.apache.org>.
Github user ajantha-bhat commented on the issue:
https://github.com/apache/carbondata/pull/2306
@ravipesala : please review
---
[GitHub] carbondata issue #2306: [CARBONDATA-2479] Multiple issue fixes in SDK writer...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2306
LGTM
---
[GitHub] carbondata issue #2306: [CARBONDATA-2479] Multiple issue fixes in SDK writer...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2306
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4727/
---
[GitHub] carbondata issue #2306: [CARBONDATA-2479] Multiple issue fixes in SDK writer...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2306
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4760/
---
[GitHub] carbondata issue #2306: [CARBONDATA-2479] Multiple issue fixes in SDK writer...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2306
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4751/
---
[GitHub] carbondata issue #2306: [CARBONDATA-2479] Multiple issue fixes in SDK writer...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2306
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4955/
---
[GitHub] carbondata issue #2306: [CARBONDATA-2479] Multiple issue fixes in SDK writer...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2306
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5925/
---
[GitHub] carbondata issue #2306: [CARBONDATA-2479] Multiple issue fixes in SDK writer...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2306
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4718/
---
[GitHub] carbondata issue #2306: [CARBONDATA-2479] Multiple issue fixes in SDK writer...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2306
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4912/
---
[GitHub] carbondata issue #2306: [CARBONDATA-2479] Multiple issue fixes in SDK writer...
Posted by ajantha-bhat <gi...@git.apache.org>.
Github user ajantha-bhat commented on the issue:
https://github.com/apache/carbondata/pull/2306
retest this please
---
[GitHub] carbondata pull request #2306: [CARBONDATA-2479] Multiple issue fixes in SDK...
Posted by ajantha-bhat <gi...@git.apache.org>.
Github user ajantha-bhat commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2306#discussion_r188838995
--- Diff: store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonWriterBuilder.java ---
@@ -540,4 +543,19 @@ private CarbonLoadModel buildLoadModel(CarbonTable table, long UUID, String task
setCsvHeader(build);
return build;
}
+
+ /**
+ * can set the sortScope to NO_SORT
+ *
+ * @param sortScope can be set to "NO_SORT" to avoid sorting during load.
+ * by default sort_scope is "LOCAL_SORT"
+ * @return updated CarbonWriterBuilder
+ */
+ public CarbonWriterBuilder sortScope(String sortScope) {
+ if (!sortScope.equalsIgnoreCase("NO_SORT")) {
--- End diff --
Removed it and also avro Timestamp issue
---
[GitHub] carbondata issue #2306: [CARBONDATA-2479] Multiple issue fixes in SDK writer...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2306
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5915/
---
[GitHub] carbondata issue #2306: [CARBONDATA-2479] Multiple issue fixes in SDK writer...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2306
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5905/
---