You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@mesos.apache.org by Kapil Arya <ka...@mesosphere.io> on 2015/01/19 23:52:38 UTC

Review Request 30052: Exposed Hook headers.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30052/
-----------------------------------------------------------

Review request for mesos, Niklas Nielsen, Till Toenshoff, and Timothy Chen.


Bugs: MESOS-2096
    https://issues.apache.org/jira/browse/MESOS-2096


Repository: mesos-git


Description
-------

Moved hook/hook.hpp to include/mesos/ and module/hook.hpp to include/mesos/module.


Diffs
-----

  src/Makefile.am 07bea1fb8f0035413f2119859e16fa4f9383f68e 
  src/examples/test_hook_module.cpp 04fd43eb3eacae0d850dd7f4e191116d20620f10 
  src/hook/hook.hpp 9401e03192e53019b80e9a29a322195250cc019b 
  src/hook/manager.hpp aadc17aa8f56f8f6ae23ed427cd344f07f7db0c7 
  src/hook/manager.cpp 6bf1ef7bdddee78a0fab1a942aa89edfd9eb719e 
  src/module/hook.hpp a7c51f2f46d075a291b2f8e980ae87fd4eee26bb 

Diff: https://reviews.apache.org/r/30052/diff/


Testing
-------

make check


Thanks,

Kapil Arya

Re: Review Request 30052: Exposed Hook headers.

Posted by Timothy Chen <tn...@apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30052/#review71738
-----------------------------------------------------------

Ship it!


Ship It!

- Timothy Chen


On Feb. 5, 2015, 3:16 a.m., Kapil Arya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30052/
> -----------------------------------------------------------
> 
> (Updated Feb. 5, 2015, 3:16 a.m.)
> 
> 
> Review request for mesos, Niklas Nielsen, Till Toenshoff, and Timothy Chen.
> 
> 
> Bugs: MESOS-2096
>     https://issues.apache.org/jira/browse/MESOS-2096
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> [9/9] Build Mesos Modules outside Mesos source tree.
> 
> Moved hook/hook.hpp to include/mesos/ and module/hook.hpp to include/mesos/module.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 93537d17d3c7604a8532ee1453e405630c481ddc 
>   src/examples/test_hook_module.cpp 04fd43eb3eacae0d850dd7f4e191116d20620f10 
>   src/hook/hook.hpp 9401e03192e53019b80e9a29a322195250cc019b 
>   src/hook/manager.hpp aadc17aa8f56f8f6ae23ed427cd344f07f7db0c7 
>   src/hook/manager.cpp 6bf1ef7bdddee78a0fab1a942aa89edfd9eb719e 
>   src/module/hook.hpp a7c51f2f46d075a291b2f8e980ae87fd4eee26bb 
> 
> Diff: https://reviews.apache.org/r/30052/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>

Re: Review Request 30052: Exposed Hook headers.

Posted by Niklas Nielsen <ni...@qni.dk>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30052/#review71734
-----------------------------------------------------------

Ship it!


Ship It!

- Niklas Nielsen


On Feb. 4, 2015, 7:16 p.m., Kapil Arya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30052/
> -----------------------------------------------------------
> 
> (Updated Feb. 4, 2015, 7:16 p.m.)
> 
> 
> Review request for mesos, Niklas Nielsen, Till Toenshoff, and Timothy Chen.
> 
> 
> Bugs: MESOS-2096
>     https://issues.apache.org/jira/browse/MESOS-2096
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> [9/9] Build Mesos Modules outside Mesos source tree.
> 
> Moved hook/hook.hpp to include/mesos/ and module/hook.hpp to include/mesos/module.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 93537d17d3c7604a8532ee1453e405630c481ddc 
>   src/examples/test_hook_module.cpp 04fd43eb3eacae0d850dd7f4e191116d20620f10 
>   src/hook/hook.hpp 9401e03192e53019b80e9a29a322195250cc019b 
>   src/hook/manager.hpp aadc17aa8f56f8f6ae23ed427cd344f07f7db0c7 
>   src/hook/manager.cpp 6bf1ef7bdddee78a0fab1a942aa89edfd9eb719e 
>   src/module/hook.hpp a7c51f2f46d075a291b2f8e980ae87fd4eee26bb 
> 
> Diff: https://reviews.apache.org/r/30052/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>

Re: Review Request 30052: Exposed Hook headers.

Posted by Kapil Arya <ka...@mesosphere.io>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30052/
-----------------------------------------------------------

(Updated Feb. 9, 2015, 9:40 p.m.)


Review request for mesos, Niklas Nielsen, Till Toenshoff, and Timothy Chen.


Changes
-------

rebased


Bugs: MESOS-2096
    https://issues.apache.org/jira/browse/MESOS-2096


Repository: mesos


Description
-------

[9/9] Build Mesos Modules outside Mesos source tree.

Moved hook/hook.hpp to include/mesos/ and module/hook.hpp to include/mesos/module.


Diffs (updated)
-----

  src/Makefile.am 93537d17d3c7604a8532ee1453e405630c481ddc 
  src/examples/test_hook_module.cpp 573ccb3ab63314533b9623bcc1f6e7a71e6c1b7d 
  src/hook/hook.hpp e31b7c9e2c2c2347df89f44823e7c3edabbb8271 
  src/hook/manager.hpp 2de59b7349a82ea9e62ccd899495ab9e83d872c4 
  src/hook/manager.cpp c14dcca09903d0f724055a9099e1b99d9a0a917b 
  src/module/hook.hpp c7edfba5ffd33449f01108133f85a33f04d3550e 

Diff: https://reviews.apache.org/r/30052/diff/


Testing
-------

make check


Thanks,

Kapil Arya

Re: Review Request 30052: Exposed Hook headers.

Posted by Kapil Arya <ka...@mesosphere.io>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30052/
-----------------------------------------------------------

(Updated Feb. 4, 2015, 10:16 p.m.)


Review request for mesos, Niklas Nielsen, Till Toenshoff, and Timothy Chen.


Changes
-------

rebased


Bugs: MESOS-2096
    https://issues.apache.org/jira/browse/MESOS-2096


Repository: mesos


Description
-------

[9/9] Build Mesos Modules outside Mesos source tree.

Moved hook/hook.hpp to include/mesos/ and module/hook.hpp to include/mesos/module.


Diffs (updated)
-----

  src/Makefile.am 93537d17d3c7604a8532ee1453e405630c481ddc 
  src/examples/test_hook_module.cpp 04fd43eb3eacae0d850dd7f4e191116d20620f10 
  src/hook/hook.hpp 9401e03192e53019b80e9a29a322195250cc019b 
  src/hook/manager.hpp aadc17aa8f56f8f6ae23ed427cd344f07f7db0c7 
  src/hook/manager.cpp 6bf1ef7bdddee78a0fab1a942aa89edfd9eb719e 
  src/module/hook.hpp a7c51f2f46d075a291b2f8e980ae87fd4eee26bb 

Diff: https://reviews.apache.org/r/30052/diff/


Testing
-------

make check


Thanks,

Kapil Arya

Re: Review Request 30052: Exposed Hook headers.

Posted by Kapil Arya <ka...@mesosphere.io>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30052/
-----------------------------------------------------------

(Updated Feb. 2, 2015, 4:09 p.m.)


Review request for mesos, Niklas Nielsen, Till Toenshoff, and Timothy Chen.


Changes
-------

rebased


Bugs: MESOS-2096
    https://issues.apache.org/jira/browse/MESOS-2096


Repository: mesos


Description
-------

[9/9] Build Mesos Modules outside Mesos source tree.

Moved hook/hook.hpp to include/mesos/ and module/hook.hpp to include/mesos/module.


Diffs (updated)
-----

  src/Makefile.am 07bea1fb8f0035413f2119859e16fa4f9383f68e 
  src/examples/test_hook_module.cpp 04fd43eb3eacae0d850dd7f4e191116d20620f10 
  src/hook/hook.hpp 9401e03192e53019b80e9a29a322195250cc019b 
  src/hook/manager.hpp aadc17aa8f56f8f6ae23ed427cd344f07f7db0c7 
  src/hook/manager.cpp 6bf1ef7bdddee78a0fab1a942aa89edfd9eb719e 
  src/module/hook.hpp a7c51f2f46d075a291b2f8e980ae87fd4eee26bb 

Diff: https://reviews.apache.org/r/30052/diff/


Testing
-------

make check


Thanks,

Kapil Arya

Re: Review Request 30052: Exposed Hook headers.

Posted by Kapil Arya <ka...@mesosphere.io>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30052/
-----------------------------------------------------------

(Updated Jan. 27, 2015, 6:51 p.m.)


Review request for mesos, Niklas Nielsen, Till Toenshoff, and Timothy Chen.


Bugs: MESOS-2096
    https://issues.apache.org/jira/browse/MESOS-2096


Repository: mesos-git


Description (updated)
-------

[9/9] Build Mesos Modules outside Mesos source tree.

Moved hook/hook.hpp to include/mesos/ and module/hook.hpp to include/mesos/module.


Diffs
-----

  src/Makefile.am 07bea1fb8f0035413f2119859e16fa4f9383f68e 
  src/examples/test_hook_module.cpp 04fd43eb3eacae0d850dd7f4e191116d20620f10 
  src/hook/hook.hpp 9401e03192e53019b80e9a29a322195250cc019b 
  src/hook/manager.hpp aadc17aa8f56f8f6ae23ed427cd344f07f7db0c7 
  src/hook/manager.cpp 6bf1ef7bdddee78a0fab1a942aa89edfd9eb719e 
  src/module/hook.hpp a7c51f2f46d075a291b2f8e980ae87fd4eee26bb 

Diff: https://reviews.apache.org/r/30052/diff/


Testing
-------

make check


Thanks,

Kapil Arya

Re: Review Request 30052: Exposed Hook headers.

Posted by Kapil Arya <ka...@mesosphere.io>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30052/
-----------------------------------------------------------

(Updated Jan. 26, 2015, 10:18 p.m.)


Review request for mesos, Niklas Nielsen, Till Toenshoff, and Timothy Chen.


Changes
-------

rebased


Bugs: MESOS-2096
    https://issues.apache.org/jira/browse/MESOS-2096


Repository: mesos-git


Description (updated)
-------

[10/10] Build Mesos Modules outside Mesos source tree.

Moved hook/hook.hpp to include/mesos/ and module/hook.hpp to include/mesos/module.


Diffs (updated)
-----

  src/Makefile.am 07bea1fb8f0035413f2119859e16fa4f9383f68e 
  src/examples/test_hook_module.cpp 04fd43eb3eacae0d850dd7f4e191116d20620f10 
  src/hook/hook.hpp 9401e03192e53019b80e9a29a322195250cc019b 
  src/hook/manager.hpp aadc17aa8f56f8f6ae23ed427cd344f07f7db0c7 
  src/hook/manager.cpp 6bf1ef7bdddee78a0fab1a942aa89edfd9eb719e 
  src/module/hook.hpp a7c51f2f46d075a291b2f8e980ae87fd4eee26bb 

Diff: https://reviews.apache.org/r/30052/diff/


Testing
-------

make check


Thanks,

Kapil Arya

Re: Review Request 30052: Exposed Hook headers.

Posted by Kapil Arya <ka...@mesosphere.io>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30052/
-----------------------------------------------------------

(Updated Jan. 23, 2015, 9:38 p.m.)


Review request for mesos, Niklas Nielsen, Till Toenshoff, and Timothy Chen.


Bugs: MESOS-2096
    https://issues.apache.org/jira/browse/MESOS-2096


Repository: mesos-git


Description
-------

Moved hook/hook.hpp to include/mesos/ and module/hook.hpp to include/mesos/module.


Diffs (updated)
-----

  src/Makefile.am 07bea1fb8f0035413f2119859e16fa4f9383f68e 
  src/examples/test_hook_module.cpp 04fd43eb3eacae0d850dd7f4e191116d20620f10 
  src/hook/hook.hpp 9401e03192e53019b80e9a29a322195250cc019b 
  src/hook/manager.hpp aadc17aa8f56f8f6ae23ed427cd344f07f7db0c7 
  src/hook/manager.cpp 6bf1ef7bdddee78a0fab1a942aa89edfd9eb719e 
  src/module/hook.hpp a7c51f2f46d075a291b2f8e980ae87fd4eee26bb 

Diff: https://reviews.apache.org/r/30052/diff/


Testing
-------

make check


Thanks,

Kapil Arya

Re: Review Request 30052: Exposed Hook headers.

Posted by Kapil Arya <ka...@mesosphere.io>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30052/
-----------------------------------------------------------

(Updated Jan. 23, 2015, 8:51 p.m.)


Review request for mesos, Niklas Nielsen, Till Toenshoff, and Timothy Chen.


Changes
-------

rebased


Bugs: MESOS-2096
    https://issues.apache.org/jira/browse/MESOS-2096


Repository: mesos-git


Description
-------

Moved hook/hook.hpp to include/mesos/ and module/hook.hpp to include/mesos/module.


Diffs (updated)
-----

  src/Makefile.am 07bea1fb8f0035413f2119859e16fa4f9383f68e 
  src/examples/test_hook_module.cpp 04fd43eb3eacae0d850dd7f4e191116d20620f10 
  src/hook/hook.hpp 9401e03192e53019b80e9a29a322195250cc019b 
  src/hook/manager.hpp aadc17aa8f56f8f6ae23ed427cd344f07f7db0c7 
  src/hook/manager.cpp 6bf1ef7bdddee78a0fab1a942aa89edfd9eb719e 
  src/module/hook.hpp a7c51f2f46d075a291b2f8e980ae87fd4eee26bb 

Diff: https://reviews.apache.org/r/30052/diff/


Testing
-------

make check


Thanks,

Kapil Arya

Re: Review Request 30052: Exposed Hook headers.

Posted by Till Toenshoff <to...@me.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30052/#review69461
-----------------------------------------------------------

Ship it!


Ship It!

- Till Toenshoff


On Jan. 22, 2015, 1:18 a.m., Kapil Arya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30052/
> -----------------------------------------------------------
> 
> (Updated Jan. 22, 2015, 1:18 a.m.)
> 
> 
> Review request for mesos, Niklas Nielsen, Till Toenshoff, and Timothy Chen.
> 
> 
> Bugs: MESOS-2096
>     https://issues.apache.org/jira/browse/MESOS-2096
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Moved hook/hook.hpp to include/mesos/ and module/hook.hpp to include/mesos/module.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 07bea1fb8f0035413f2119859e16fa4f9383f68e 
>   src/examples/test_hook_module.cpp 04fd43eb3eacae0d850dd7f4e191116d20620f10 
>   src/hook/hook.hpp 9401e03192e53019b80e9a29a322195250cc019b 
>   src/hook/manager.hpp aadc17aa8f56f8f6ae23ed427cd344f07f7db0c7 
>   src/hook/manager.cpp 6bf1ef7bdddee78a0fab1a942aa89edfd9eb719e 
>   src/module/hook.hpp a7c51f2f46d075a291b2f8e980ae87fd4eee26bb 
> 
> Diff: https://reviews.apache.org/r/30052/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>

Re: Review Request 30052: Exposed Hook headers.

Posted by Kapil Arya <ka...@mesosphere.io>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30052/
-----------------------------------------------------------

(Updated Jan. 21, 2015, 8:18 p.m.)


Review request for mesos, Niklas Nielsen, Till Toenshoff, and Timothy Chen.


Changes
-------

rebased.


Bugs: MESOS-2096
    https://issues.apache.org/jira/browse/MESOS-2096


Repository: mesos-git


Description
-------

Moved hook/hook.hpp to include/mesos/ and module/hook.hpp to include/mesos/module.


Diffs (updated)
-----

  src/Makefile.am 07bea1fb8f0035413f2119859e16fa4f9383f68e 
  src/examples/test_hook_module.cpp 04fd43eb3eacae0d850dd7f4e191116d20620f10 
  src/hook/hook.hpp 9401e03192e53019b80e9a29a322195250cc019b 
  src/hook/manager.hpp aadc17aa8f56f8f6ae23ed427cd344f07f7db0c7 
  src/hook/manager.cpp 6bf1ef7bdddee78a0fab1a942aa89edfd9eb719e 
  src/module/hook.hpp a7c51f2f46d075a291b2f8e980ae87fd4eee26bb 

Diff: https://reviews.apache.org/r/30052/diff/


Testing
-------

make check


Thanks,

Kapil Arya