You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/01/15 21:23:37 UTC

[GitHub] [airflow] kaxil commented on a change in pull request #7172: [AIRFLOW-6564] Additional diagnostics information on CI check failure

kaxil commented on a change in pull request #7172: [AIRFLOW-6564] Additional diagnostics information on CI check failure
URL: https://github.com/apache/airflow/pull/7172#discussion_r367114338
 
 

 ##########
 File path: airflow/bin/cli.py
 ##########
 @@ -837,6 +837,12 @@ class CLIFactory:
             'help': "Runs a shell to access the database",
             'args': tuple(),
         },
+        {
+            'func': lazy_load_command('airflow.cli.commands.db_command.check'),
+            'name': 'check',
+            'help': "Chack if the database can be reached.",
+            'args': tuple(),
+        },
 
 Review comment:
   We have the `/health` endpoint already, do you think that would cover this and we won't need a new command?
   
   Endpoint: https://github.com/apache/airflow/blob/master/airflow/www/views.py#L182-L210
   
   >An endpoint helping check the health status of the Airflow instance, including metadatabase and scheduler.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services