[GitHub] [hbase] javierluca commented on a change in pull request #3054: HBOPS-25594 Make easier to use graceful_stop on localhost mode

[GitBox <gi...@apache.org>]

javierluca commented on a change in pull request #3054:
URL: https://github.com/apache/hbase/pull/3054#discussion_r595138244



##########
File path: bin/graceful_stop.sh
##########
@@ -108,6 +108,10 @@ localhostname=`/bin/hostname -f`
 if [ "$localhostname" == "$hostname" ]; then
   local=true
 fi
+if [ "$localhostname" == "$hostname" ] || [ "$hostname" == "localhost" ]; then
+  local=true
+  hostname=$localhostname

Review comment:
       From my understanding, passing "localhost" to `regionserver.sh` is meant to be used in pseudo-distributed environments. See:
   - https://issues.apache.org/jira/browse/HBASE-15924?focusedCommentId=16410243&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16410243
   - https://issues.apache.org/jira/browse/HBASE-20130
   
   And it would use fixed ports:
   https://github.com/apache/hbase/blob/d74ae15fa7a110d3e2b35bf53d8823ba0b1bb33b/bin/regionservers.sh#L61-L64
   
   Since I want to avoid that, let me reassign hostname to the fqdn here.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org