[jira] [Created] (ZEPPELIN-832) Notebook.CronJob.execute checks if last paragraph is terminated; this doesn't work for parallel schedulers

["Prasad Wagle (JIRA)" <ji...@apache.org>]

Prasad Wagle created ZEPPELIN-832:
-------------------------------------

             Summary: Notebook.CronJob.execute checks if last paragraph is terminated; this doesn't work for parallel schedulers
                 Key: ZEPPELIN-832
                 URL: https://issues.apache.org/jira/browse/ZEPPELIN-832
             Project: Zeppelin
          Issue Type: Bug
            Reporter: Prasad Wagle


On Mon, Apr 25, 2016 at 9:54 PM, moon soo Lee <mo...@apache.org> wrote:
Hi Prasad,

Good catch. While Notebook.CronJob.execute checks only last last paragraph, it'll misbehave when parallel scheduler is used or paragraphs uses different interpreters. I think this should be fixed.

On Mon, Apr 25, 2016 at 3:44 PM Prasad Wagle <pr...@gmail.com> wrote:
Cron Job

In Notebook.CronJob.execute, we check note.getLastParagraph().isTerminated()? How would this work if paragraphs in the note use different interpreters or if the interpreter uses parallel scheduler?

  public static class CronJob implements org.quartz.Job {
    public static Notebook notebook;

    public void execute(JobExecutionContext context) throws JobExecutionException {

      String noteId = context.getJobDetail().getJobDataMap().getString("noteId");
      Note note = notebook.getNote(noteId);
      note.runAll();

      while (!note.getLastParagraph().isTerminated()) {
        try {
          Thread.sleep(1000);
        } catch (InterruptedException e) {
          logger.error(e.toString(), e);
        }
      }



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)