You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/09/17 14:28:24 UTC

[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #1816: input: Add SPI mode for STMPE811 touch screen controller

patacongo commented on a change in pull request #1816:
URL: https://github.com/apache/incubator-nuttx/pull/1816#discussion_r490291913



##########
File path: drivers/input/stmpe811_base.c
##########
@@ -422,18 +443,21 @@ uint8_t stmpe811_getreg8(FAR struct stmpe811_dev_s *priv, uint8_t regaddr)
  *
  ****************************************************************************/
 
-#ifdef CONFIG_STMPE811_I2C
 void stmpe811_putreg8(FAR struct stmpe811_dev_s *priv,
                       uint8_t regaddr, uint8_t regval)
 {
   /* 8-bit data read sequence:
    *
-   *  Start - I2C_Write_Address - STMPE811_Reg_Address - STMPE811_Write_Data - STOP
+   *  Start - I2C_Write_Address - STMPE811_Reg_Address -

Review comment:
       ```suggestion
      * i2c:
      *   Start - I2C_Write_Address - STMPE811_Reg_Address -
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org