[jira] [Commented] (SOLR-12336) Remove Filter from Solr

["Mike Drob (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SOLR-12336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17488193#comment-17488193 ] 

Mike Drob commented on SOLR-12336:
----------------------------------

I looked through the ref guide and didn't see anything that looks like it references Filter or SolrConstantScoreQuery, the classes that are under proposal for removal. All of the usages of Filter looked like they were the plain English usage, not referring to the Filter class.

> Remove Filter from Solr
> -----------------------
>
>                 Key: SOLR-12336
>                 URL: https://issues.apache.org/jira/browse/SOLR-12336
>             Project: Solr
>          Issue Type: Improvement
>          Components: search
>            Reporter: David Smiley
>            Assignee: David Smiley
>            Priority: Major
>             Fix For: 9.0
>
>          Time Spent: 9h 50m
>  Remaining Estimate: 0h
>
> Over a series of Lucene releases, the old Filter was made to extend Query (LUCENE-1518) and then was removed from Lucene (moved to Solr in LUCENE-6583); BooleanClause.Occur.FILTER (LUCENE-6227) with some other API enhancements including TwoPhaseIterator replaced the need for the old Filter.  Filter is now a Solr thing, and there are various related classes like QueryWrapperFilter and SolrConstantScoreQuery that depend on it.  We should remove some of this technical-debt / bit-rot, making refactorings as needed to retain functionality.  Leaving things as-is is needless complexity and can impede performance when there is needless wrapping/layers.
> CC @yonik



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org