[jira] [Closed] (KAFKA-793) Include controllerId in all requests sent by controller

["Neha Narkhede (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/KAFKA-793?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Neha Narkhede closed KAFKA-793.
-------------------------------

    
> Include controllerId in all requests sent by controller
> -------------------------------------------------------
>
>                 Key: KAFKA-793
>                 URL: https://issues.apache.org/jira/browse/KAFKA-793
>             Project: Kafka
>          Issue Type: Bug
>    Affects Versions: 0.8
>            Reporter: Swapnil Ghike
>            Assignee: Swapnil Ghike
>            Priority: Blocker
>              Labels: kafka-0.8, p1
>             Fix For: 0.8
>
>         Attachments: kafka-793-v1.patch
>
>
> As part of KAFKA-513, we added controllerId in LeaderAndIsrRequest. We should add that to all requests sent by the controller, such as StopReplicaRequest.
> Other small issues that can be taken care of by this jira:
> 1. The string "state.change.logger" is used in many places. We should create a constant val and reuse the val to avoid human mistakes.
> 2. Remove the private constructor from ControllerChannelManager.
> 3. Remove default from jsonFileOpt in PreferredReplicaLeaderElectionCommand, because the default is only used to indicate an absense of a legitimate jsonFile. We can check the same using if(options.has(jsonFileOpt))

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira