You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2020/01/24 16:46:44 UTC
[GitHub] [trafficcontrol] ocket8888 opened a new pull request #4331: Added
deprecation notice to /hwinfo/dtdata
ocket8888 opened a new pull request #4331: Added deprecation notice to /hwinfo/dtdata
URL: https://github.com/apache/trafficcontrol/pull/4331
## What does this PR (Pull Request) do?
- [x] This PR "fixes" #3799
This adds a new method to `MojoPlugins::Response` instances called `deprecate_with_no_alternative` for deprecation alerts when no alternative exists. It also changes the `/hwinfo/dtdata` handler to use it.
## Which Traffic Control components are affected by this PR?
- Traffic Ops
Not adding documentation for a deprecated route.
## What is the best way to verify this PR?
You actually can't. The endpoint is currently broken in master, and I didn't want to fix an endpoint that's been broken for gods know how long, with no apparent purpose, and is already deprecated. This way, though, if it is ever fixed it'll have a deprecation notice. Plus I think the helper is still useful for other endpoints where there's no alternative to something that's deprecated.
## The following criteria are ALL met by this PR
- [x] Tests are unnecessary
- [x] I have explained why documentation is unnecessary
- [x] An update to CHANGELOG.md is not necessary
- [x] This PR includes any and all required license headers
- [x] This PR does not include a database migration
- [x] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY**
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [trafficcontrol] mitchell852 merged pull request #4331: Added
deprecation notice to /hwinfo/dtdata
Posted by GitBox <gi...@apache.org>.
mitchell852 merged pull request #4331: Added deprecation notice to /hwinfo/dtdata
URL: https://github.com/apache/trafficcontrol/pull/4331
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services