[jira] [Commented] (FLINK-8678) Make AkkaRpcService#stopService non-blocking

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-8678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16368200#comment-16368200 ] 

ASF GitHub Bot commented on FLINK-8678:
---------------------------------------

GitHub user tillrohrmann opened a pull request:

    https://github.com/apache/flink/pull/5517

    [FLINK-8678] [flip6] Make RpcService shut down non blocking

    ## What is the purpose of the change
    
    Changes the RpcService#stopService method to be non blocking. Instead
    of waiting until the RpcService has stopped, it returns the termination
    future which is completed once the RpcService has been completelyshut
    down.
    
    ## Verifying this change
    
    This change is already covered by existing tests.
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (no)
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
      - The serializers: (no)
      - The runtime per-record code paths (performance sensitive): (no)
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
      - The S3 file system connector: (no)
    
    ## Documentation
    
      - Does this pull request introduce a new feature? (no)
      - If yes, how is the feature documented? (not applicable)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tillrohrmann/flink nonBlockingRpcServiceShutDown

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/5517.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5517
    
----
commit 5026fb052ba995f775ff3b6809f6cebdfd207140
Author: Till Rohrmann <tr...@...>
Date:   2018-02-16T17:46:42Z

    [FLINK-8678] [flip6] Make RpcService shut down non blocking
    
    Changes the RpcService#stopService method to be non blocking. Instead
    of waiting until the RpcService has stopped, it returns the termination
    future which is completed once the RpcService has been completelyshut
    down.

----


> Make AkkaRpcService#stopService non-blocking
> --------------------------------------------
>
>                 Key: FLINK-8678
>                 URL: https://issues.apache.org/jira/browse/FLINK-8678
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Distributed Coordination
>    Affects Versions: 1.5.0
>            Reporter: Till Rohrmann
>            Assignee: Till Rohrmann
>            Priority: Major
>              Labels: flip-6
>             Fix For: 1.5.0
>
>
> In order to properly shut down the {{AkkaRpcService}} in a non-blocking fashion, we have to change the implementation of the {{AkkaRpcService#stopService}}. This would give us the benefit to enable non-blocking shut down of the components owning the {{AkkaRpcService}}.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)