You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@celeborn.apache.org by GitBox <gi...@apache.org> on 2022/11/29 09:06:39 UTC
[GitHub] [incubator-celeborn] zhongqiangczq opened a new pull request, #1025: [CELEBORN-80] FileWriter supports MapPartition
zhongqiangczq opened a new pull request, #1025:
URL: https://github.com/apache/incubator-celeborn/pull/1025
# [BUG]/[FEATURE] title
### What changes were proposed in this pull request?
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
### What are the items that need reviewer attention?
### Related issues.
### Related pull requests.
### How was this patch tested?
/cc @related-reviewer
@waitinfuture @FMX @RexXiong
/assign @main-reviewer
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] RexXiong commented on a diff in pull request #1025: [CELEBORN-80] FileWriter supports MapPartition
Posted by GitBox <gi...@apache.org>.
RexXiong commented on code in PR #1025:
URL: https://github.com/apache/incubator-celeborn/pull/1025#discussion_r1036750937
##########
common/src/main/java/org/apache/celeborn/common/meta/FileInfo.java:
##########
@@ -102,6 +102,10 @@ public String getIndexPath() {
return Utils.getIndexFilePath(filePath);
}
+ public String getIndexPathMapPartition() {
Review Comment:
is there any chance to use one index path for both map/reduce partition
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] RexXiong commented on a diff in pull request #1025: [CELEBORN-80] FileWriter supports MapPartition
Posted by GitBox <gi...@apache.org>.
RexXiong commented on code in PR #1025:
URL: https://github.com/apache/incubator-celeborn/pull/1025#discussion_r1036810067
##########
worker/src/main/java/org/apache/celeborn/service/deploy/worker/storage/FileWriter.java:
##########
@@ -119,6 +162,8 @@ public FileWriter(
this.mapIdBitMap = new RoaringBitmap();
}
takeBuffer();
+
+ initMapPartition();
Review Comment:
suggest just use initialize() method
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] RexXiong commented on a diff in pull request #1025: [CELEBORN-80] FileWriter supports MapPartition
Posted by GitBox <gi...@apache.org>.
RexXiong commented on code in PR #1025:
URL: https://github.com/apache/incubator-celeborn/pull/1025#discussion_r1036810882
##########
worker/src/main/java/org/apache/celeborn/service/deploy/worker/storage/FileWriter.java:
##########
@@ -189,12 +234,19 @@ public void write(ByteBuf data) throws IOException {
}
int mapId = 0;
- if (rangeReadFilter) {
Review Comment:
suggest extract a method for getMapId
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] waitinfuture merged pull request #1025: [CELEBORN-80] FileWriter supports MapPartition
Posted by GitBox <gi...@apache.org>.
waitinfuture merged PR #1025:
URL: https://github.com/apache/incubator-celeborn/pull/1025
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org