[jira] [Updated] (HDFS-3809) Make BKJM use protobufs for all serialization with ZK

["Ivan Kelly (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/HDFS-3809?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ivan Kelly updated HDFS-3809:
-----------------------------

    Attachment: HDFS-3809.diff

New patch addresses comments.

{quote}
One doubt, Do we need to handle existing BKJM layout data compatibility, while reading the existing ledgers..?
{quote}
The current layout is only in the -alpha releases, which are marked as such because APIs haven't been finalized. This can be considered part of this.

{quote}
CURRENT_INPROGRESS_LAYOUT_VERSION version check is removed from the CurrentInprogress.java, do you think this version check not required. In that case CURRENT_INPROGRESS_LAYOUT_VERSION
and also CONTENT_DELIMITER can be removed from CurrentInprogress.java
{quote}
Protobufs remove the need for an explicit inprogress layout version.

{quote}
In CurrentInprogressProto, why hostName is made optional.? is there any specific reason for it..? But i can see that previously always hostname was present in data.
{quote}
It's optional because it's not strictly necessary to function. It's just convenient for debugging. Protobuf guidelines suggest that you always make things optional unless they absolutely need to be there.

                
> Make BKJM use protobufs for all serialization with ZK
> -----------------------------------------------------
>
>                 Key: HDFS-3809
>                 URL: https://issues.apache.org/jira/browse/HDFS-3809
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: name-node
>    Affects Versions: 2.0.0-alpha, 3.0.0
>            Reporter: Ivan Kelly
>            Assignee: Ivan Kelly
>         Attachments: HDFS-3809.diff, HDFS-3809.diff, HDFS-3809.diff
>
>
> HDFS uses protobufs for serialization in many places. Protobufs allow fields to be added without breaking bc or requiring new parsing code to be written. For this reason, we should use them in BKJM also.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira