You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "1782935682 (via GitHub)" <gi...@apache.org> on 2025/11/28 01:59:46 UTC
[PR] Support configurable namespace parsing [rocketmq]
1782935682 opened a new pull request, #9878:
URL: https://github.com/apache/rocketmq/pull/9878
feat(proxy): add switch to disable automatic namespace stripping
When a topic is named in the format `Namespace%Topic` (e.g., `111%222`), the Proxy previously truncated it to just `222`. This caused message send/receive errors and ACL authentication failures due to resource name mismatches.
This commit introduces a configuration option to disable this automatic namespace parsing, allowing topics to retain their full name structure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Support configurable namespace parsing [rocketmq]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #9878:
URL: https://github.com/apache/rocketmq/pull/9878#issuecomment-3587726223
## [Codecov](https://app.codecov.io/gh/apache/rocketmq/pull/9878?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `27.27273%` with `16 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 48.29%. Comparing base ([`63d20eb`](https://app.codecov.io/gh/apache/rocketmq/commit/63d20eb92a4aa685ae0d0696b419d3ffb6ca1738?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`b0b26e3`](https://app.codecov.io/gh/apache/rocketmq/commit/b0b26e31f6ca0d73587e25219da1337c28528547?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/rocketmq/pull/9878?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...e/rocketmq/proxy/grpc/v2/common/GrpcConverter.java](https://app.codecov.io/gh/apache/rocketmq/pull/9878?src=pr&el=tree&filepath=proxy%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Frocketmq%2Fproxy%2Fgrpc%2Fv2%2Fcommon%2FGrpcConverter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cHJveHkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3Byb3h5L2dycGMvdjIvY29tbW9uL0dycGNDb252ZXJ0ZXIuamF2YQ==) | 22.22% | [12 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/rocketmq/pull/9878?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../org/apache/rocketmq/proxy/config/ProxyConfig.java](https://app.codecov.io/gh/apache/rocketmq/pull/9878?src=pr&el=tree&filepath=proxy%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Frocketmq%2Fproxy%2Fconfig%2FProxyConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cHJveHkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3Byb3h5L2NvbmZpZy9Qcm94eUNvbmZpZy5qYXZh) | 50.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/rocketmq/pull/9878?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## develop #9878 +/- ##
=============================================
- Coverage 48.38% 48.29% -0.10%
+ Complexity 12282 12258 -24
=============================================
Files 1314 1314
Lines 93903 93921 +18
Branches 12046 12047 +1
=============================================
- Hits 45438 45357 -81
- Misses 42856 42942 +86
- Partials 5609 5622 +13
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/rocketmq/pull/9878?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] add config to disable namespace stripping to support topics containing '%' [rocketmq]
Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins commented on PR #9878:
URL: https://github.com/apache/rocketmq/pull/9878#issuecomment-3673737680
@qianye1001 @RongtongJin Please consider this matter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org