You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/04/23 09:12:45 UTC
[GitHub] [flink] carryxyh commented on a change in pull request #8243:
[FLINK-12299] ExecutionConfig#setAutoWatermarkInterval should check
param(interval should not less than zero)
carryxyh commented on a change in pull request #8243: [FLINK-12299] ExecutionConfig#setAutoWatermarkInterval should check param(interval should not less than zero)
URL: https://github.com/apache/flink/pull/8243#discussion_r277584465
##########
File path: flink-core/src/main/java/org/apache/flink/api/common/ExecutionConfig.java
##########
@@ -220,6 +219,7 @@ public boolean isClosureCleanerEnabled() {
*/
@PublicEvolving
public ExecutionConfig setAutoWatermarkInterval(long interval) {
+ Preconditions.checkArgument(interval > 0, "The interval must be greater than 0.");
Review comment:
Hi, I don't think this can be equal to 0.
In the case of equal to 0, it actually causes the watermark to remain at Long.MIN_VALUE, which is not what we want.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services