[GitHub] [incubator-iotdb] qiaojialin commented on a change in pull request #1367: [IOTDB-749] Handle select * from root OOM

[GitBox <gi...@apache.org>]

qiaojialin commented on a change in pull request #1367:
URL: https://github.com/apache/incubator-iotdb/pull/1367#discussion_r441347520



##########
File path: server/src/main/java/org/apache/iotdb/db/conf/IoTDBDescriptor.java
##########
@@ -676,6 +678,8 @@ private void initMemoryAllocate(Properties properties) {
             maxMemoryAvailable * Integer.parseInt(proportions[1].trim()) / proportionSum);
         conf.setAllocateMemoryForTimeSeriesMetaDataCache(
             maxMemoryAvailable * Integer.parseInt(proportions[2].trim()) / proportionSum);
+        conf.setAllocateMemoryForReadWithoutCache(
+            maxMemoryAvailable * Integer.parseInt(proportions[3].trim()) / proportionSum);

Review comment:
       rename the maxMemoryAvailable to memoryForRead

##########
File path: server/src/assembly/resources/conf/iotdb-engine.properties
##########
@@ -226,6 +226,10 @@ write_read_free_memory_proportion=6:3:1
 # primitive array size (length of each array) in array pool
 primitive_array_size=128
 
+# allowed max numbers of deduplicated path in one query
+# it's just an advised value, the real limitation will be the smaller one between this and the one we calculated
+max_deduplicated_path_num=10000

Review comment:
       reduce to 1000?

##########
File path: server/src/main/java/org/apache/iotdb/db/conf/IoTDBConfig.java
##########
@@ -128,6 +128,8 @@
    */
   private long allocateMemoryForRead = Runtime.getRuntime().maxMemory() * 3 / 10;
 
+  private long allocateMemoryForReadWithoutCache = Runtime.getRuntime().maxMemory() * 21 / 100;

Review comment:
       20% for read without cache?   Should it be allocateMemoryForRead * 70%?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org