You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2019/01/15 08:34:37 UTC

[GitHub] rhtyd commented on a change in pull request #3099: Add resource UUID instead of resource id in resourcedetails api (#2527)

rhtyd commented on a change in pull request #3099: Add resource UUID instead of resource id in resourcedetails api (#2527)
URL: https://github.com/apache/cloudstack/pull/3099#discussion_r247799801
 
 

 ##########
 File path: server/src/main/java/com/cloud/api/query/QueryManagerImpl.java
 ##########
 @@ -342,15 +342,15 @@
     private TemplateJoinDao _templateJoinDao;
 
     @Inject
-    ResourceManager _resourceMgr;
+    private ResourceManager _resourceMgr;
     @Inject
     private ResourceMetaDataService _resourceMetaDataMgr;
 
     @Inject
     private TaggedResourceService _taggedResourceMgr;
 
     @Inject
-    AffinityGroupVMMapDao _affinityGroupVMMapDao;
+    private AffinityGroupVMMapDao _affinityGroupVMMapDao;
 
 Review comment:
   @anuragaw can you submit the cleanup PR separately to cleanup the `_`, I must note that it's a rampant issue throughout the codebase. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services