You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/11/15 19:21:09 UTC
[GitHub] [beam] scott-strong opened a new pull request, #24180: Using Teardown context instead of deprecated finalize
scott-strong opened a new pull request, #24180:
URL: https://github.com/apache/beam/pull/24180
This method is deprecated as of Java 9. I have also been having trouble with connections leaking and staying open after encountering database errors and think this is the culprit.
I believe this is also the issue occurring in #22299
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/get-started-contributing/#make-the-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Abacn merged pull request #24180: Using Teardown context instead of deprecated finalize
Posted by GitBox <gi...@apache.org>.
Abacn merged PR #24180:
URL: https://github.com/apache/beam/pull/24180
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Abacn commented on pull request #24180: Using Teardown context instead of deprecated finalize
Posted by GitBox <gi...@apache.org>.
Abacn commented on PR #24180:
URL: https://github.com/apache/beam/pull/24180#issuecomment-1315882703
> @Abacn thanks yeah that's fair, but does `FinishBundle` get called even if `processElement` encounters an exception? That's the use case I was looking to fix.
FinishBundle will not get called; TearDown will. There are unit tests for this: https://github.com/apache/beam/blob/master/sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/ParDoLifecycleTest.java
And realized we should have better documentation for ParDo life cycles.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Abacn commented on pull request #24180: Using Teardown context instead of deprecated finalize
Posted by GitBox <gi...@apache.org>.
Abacn commented on PR #24180:
URL: https://github.com/apache/beam/pull/24180#issuecomment-1315883553
performance test passed. Thanks for the fix! Will monitor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Abacn commented on pull request #24180: Using Teardown context instead of deprecated finalize
Posted by GitBox <gi...@apache.org>.
Abacn commented on PR #24180:
URL: https://github.com/apache/beam/pull/24180#issuecomment-1315802654
Thanks for the catch! Entered #24181 for tracking.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #24180: Using Teardown context instead of deprecated finalize
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #24180:
URL: https://github.com/apache/beam/pull/24180#issuecomment-1315833888
Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @robertwb for label java.
R: @pabloem for label io.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Abacn commented on pull request #24180: Using Teardown context instead of deprecated finalize
Posted by GitBox <gi...@apache.org>.
Abacn commented on PR #24180:
URL: https://github.com/apache/beam/pull/24180#issuecomment-1315803121
Run Java JdbcIO Performance Test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] scott-strong commented on pull request #24180: Using Teardown context instead of deprecated finalize
Posted by GitBox <gi...@apache.org>.
scott-strong commented on PR #24180:
URL: https://github.com/apache/beam/pull/24180#issuecomment-1315810639
@Abacn thanks yeah that's fair, but does `FinishBundle` get called even if `processElement` encounters an exception? That's the use case I was looking to fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org