Re: [PR] [CELEBORN-1263] Fix Master HA mode without internal port error [incubator-celeborn]

["wxplovecc (via GitHub)" <gi...@apache.org>]

wxplovecc commented on code in PR #2283:
URL: https://github.com/apache/incubator-celeborn/pull/2283#discussion_r1477194042


##########
master/src/main/scala/org/apache/celeborn/service/deploy/master/MasterArguments.scala:
##########
@@ -44,7 +44,9 @@ class MasterArguments(args: Array[String], conf: CelebornConf) {
     val localNode = clusterInfo.localNode
     _host = _host.orElse(Some(conf.haMasterNodeHost(localNode.nodeId)))
     _port = _port.orElse(Some(conf.haMasterNodePort(localNode.nodeId)))
-    _internalPort = _internalPort.orElse(Some(conf.haMasterNodeInternalPort(localNode.nodeId)))
+    _internalPort = _internalPort.orElse { 

Review Comment:
   +1



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org