You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@knox.apache.org by "smolnar82 (via GitHub)" <gi...@apache.org> on 2026/09/01 10:05:31 UTC
[PR] KNOX-3429: Harden source assembly to exclude build caches, runtime state, and staging dir [knox]
smolnar82 opened a new pull request, #1368:
URL: https://github.com/apache/knox/pull/1368
[KNOX-3429](https://issues.apache.org/jira/browse/KNOX-3429) - Harden source assembly to exclude build caches, runtime state, and staging dir
## What changes were proposed in this pull request?
`src/assembly.xml` includes `**` from the repo root and excluded only `target/`, `node_modules/`, and `IDE files`. Since it snapshots the working tree at end-of-build, leftover artifacts get bundled into `knox-<version>-src.zip` - bloating it (staging then fails with `svn E175002` on the `dist` repo) and shipping generated `keystores/credentials` in a source release.
Adds scoped excludes:
- .angular/.scannerwork caches
- candidate/** (re-bundled a previous *-src.zip)
- runtime state outside target/ (data/{security,ldap-server,deployments}, logs, *.pid)
- and JVM crash/heap dumps.
Kept narrow (**/logs/*.log not **/*.log) to drop no tracked source. Safety net only - staging from a clean checkout remains recommended.
How was this patch tested?
```
- xmllint --noout src/assembly.xml passes.
- git ls-files confirms no new pattern matches tracked source (preserves home/data/**/README, home/logs/.gitignore, sample .log).
- Clean-checkout build already yields the correct ~38 MB zip; excludes now make a dirty tree produce the same.
```
Integration Tests
N/A
UI changes
N/A
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@knox.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KNOX-3429: Harden source assembly to exclude build caches, runtime state, and staging dir [knox]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #1368:
URL: https://github.com/apache/knox/pull/1368#issuecomment-5492973780
## Test Results
4 files 4 suites 13s ⏱️
69 tests 69 ✅ 0 💤 0 ❌
80 runs 80 ✅ 0 💤 0 ❌
Results for commit c3686c26.
[test-results]:data:application/gzip;base64,H4sIAGixlmoC/12Myw6CMBBFf4V07aJYmLT+jCkDk0wEavpYEf/dQixWd/ecm5xNEM9TELemuzQiJI4njMnbyG7N2KrM+Yn7B6bAPSTEP/PgZzbyFGR5/hGT985/jE/rXtRll2Alvr2Dq9zBdQ3dsnDMIFCBBryCITPgqPXQqw7I2BEsEaJUpgeJLYnXG0VVjDgAAQAA
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@knox.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KNOX-3429: Harden source assembly to exclude build caches, runtime state, and staging dir [knox]
Posted by "smolnar82 (via GitHub)" <gi...@apache.org>.
smolnar82 merged PR #1368:
URL: https://github.com/apache/knox/pull/1368
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@knox.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org